From owner-svn-src-head@FreeBSD.ORG Sat Aug 24 19:03:18 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 27493BD8; Sat, 24 Aug 2013 19:03:18 +0000 (UTC) (envelope-from ken@kdm.org) Received: from nargothrond.kdm.org (nargothrond.kdm.org [70.56.43.81]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DF8C22DFD; Sat, 24 Aug 2013 19:03:17 +0000 (UTC) Received: from nargothrond.kdm.org (localhost [127.0.0.1]) by nargothrond.kdm.org (8.14.2/8.14.2) with ESMTP id r7OJ3AqJ062806; Sat, 24 Aug 2013 13:03:10 -0600 (MDT) (envelope-from ken@nargothrond.kdm.org) Received: (from ken@localhost) by nargothrond.kdm.org (8.14.2/8.14.2/Submit) id r7OJ3AaL062805; Sat, 24 Aug 2013 13:03:10 -0600 (MDT) (envelope-from ken) Date: Sat, 24 Aug 2013 13:03:10 -0600 From: "Kenneth D. Merry" To: Glen Barber Subject: Re: svn commit: r254760 - in head: share/man/man4 sys/cam/scsi sys/kern sys/sys Message-ID: <20130824190310.GA62787@nargothrond.kdm.org> References: <201308240452.r7O4qMji033904@svn.freebsd.org> <20130824164446.GA41859@glenbarber.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130824164446.GA41859@glenbarber.us> User-Agent: Mutt/1.4.2i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2013 19:03:18 -0000 On Sat, Aug 24, 2013 at 12:44:46 -0400, Glen Barber wrote: > On Sat, Aug 24, 2013 at 04:52:22AM +0000, Kenneth D. Merry wrote: > > Author: ken > > Date: Sat Aug 24 04:52:22 2013 > > New Revision: 254760 > > URL: http://svnweb.freebsd.org/changeset/base/254760 > > > > > [...] > > > @@ -83,6 +113,17 @@ physio(struct cdev *dev, struct uio *uio > > */ > > iolen = ((vm_offset_t) bp->b_data) & PAGE_MASK; > > if ((bp->b_bcount + iolen) > bp->b_kvasize) { > > + /* > > + * This device does not want I/O to be split. > > + */ > > + if (dev->si_flags & SI_NOSPLIT) { > > + printf("%s: request ptr %#jx is not " > > + "on a page boundary, cannot split " > > + "request\n", devtoname(dev), > > + (uintmax_t)bp->b_data); > > This breaks LINT for at least powerpc. > > cc1: warnings being treated as errors > /src/sys/kern/kern_physio.c: In function 'physio': > /src/sys/kern/kern_physio.c:123: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > *** Error code 1 > > > http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-powerpc-powerpc.full Oops, sorry about that! Fixed. Ken -- Kenneth Merry ken@FreeBSD.ORG