From owner-freebsd-questions@FreeBSD.ORG Mon Jul 11 20:40:49 2011 Return-Path: Delivered-To: freebsd-questions@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8F021065672; Mon, 11 Jul 2011 20:40:49 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by mx1.freebsd.org (Postfix) with ESMTP id 8F8BC8FC12; Mon, 11 Jul 2011 20:40:49 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.4/8.14.4) with ESMTP id p6BKenYF099021; Mon, 11 Jul 2011 13:40:49 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.4/8.14.4/Submit) id p6BKenuY099020; Mon, 11 Jul 2011 13:40:49 -0700 (PDT) (envelope-from sgk) Date: Mon, 11 Jul 2011 13:40:49 -0700 From: Steve Kargl To: Arnaud Lacombe Message-ID: <20110711204049.GA98996@troutmask.apl.washington.edu> References: <20110706162811.GA68436@troutmask.apl.washington.edu> <20110706193636.GA69550@troutmask.apl.washington.edu> <4E14CCE5.4050906@zedat.fu-berlin.de> <20110707015151.GB71966@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Mailman-Approved-At: Mon, 11 Jul 2011 21:02:43 +0000 Cc: Adrian Chadd , FreeBSD Current , "Hartmann, O." , arrowdodger <6yearold@gmail.com>, freebsd-questions@freebsd.org Subject: Re: Heavy I/O blocks FreeBSD box for several seconds X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2011 20:40:49 -0000 On Mon, Jul 11, 2011 at 04:33:44PM -0400, Arnaud Lacombe wrote: > > For the record, I would like to see enforced public review for _every_ > patch *before* it is checked in, as a strong rule. gcc system is > particularly interesting. But it is not likely to happen in FreeBSD > where FreeBSD committers are clearly more free than other at > checking-in un-publicly-reviewed stuff (especially _bad_ stuff). > > This would of course apply even to long-time committers, no matter how > it hurt their ego (which I definitively do not care about). > As a long time GCC committer, I think that you have grossly over-simplified the GCC review process and how a submitted patch is approved for committing. -- Steve