Date: Wed, 23 Aug 2017 17:49:22 +0200 From: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448620 - in head: devel/leatherman/files devel/llvm-devel/files sysutils/facter/files x11-wm/cde/files Message-ID: <20170823154922.GA47318@blogreen.org> In-Reply-To: <3180d43a-c87d-54cb-7a6a-61ff05669c58@FreeBSD.org> References: <201708231403.v7NE38mL020611@repo.freebsd.org> <20170823144023.GD13824@blogreen.org> <92421b70-4930-f0f0-3d04-c225c00ab7e9@FreeBSD.org> <20170823145830.GE13824@blogreen.org> <3180d43a-c87d-54cb-7a6a-61ff05669c58@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 23, 2017 at 05:32:53PM +0200, Mathieu Arnold wrote: > I do not really understand what this patch is trying to achieve >=20 > Baptiste and I only talked about patches, there are no patches in it. Okay, I might be missing something basic=E2=80=A6 $FreeBSD$ may be expanded to something that gives information about the svn revision the file was last modified. For this to happen, the 'svn:keywords' property should be set to something like 'FreeBSD=3D%H'. At some point, it was decided that this information was useless for patches and such lines where removed from them. I don't really see value here for the removal, but I agree that those keywords did not really bring value neither, so this looks OK to me. We have many files with "$FreeBSD$" in them and without svn:keywords set. There is therefore no keyword expansion in them, and I don't see more value added by these "$FreeBSD$" strings in these files than in patches=E2=80=A6 Hence the proposed patch to remove them. If these non-expanded keyword make sense for non-patches and do not make sense for patches, please explain this to me why, because I really don't understand the difference :-S. Thanks! --=20 Romain Tarti=C3=A8re <romain@FreeBSD.org> http://people.FreeBSD.org/~romai= n/ pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F) (plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated) --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCAAdFiEEgjSaeOfAuAcLWYD/uk0dlVESM28FAlmdpAEACgkQuk0dlVES M29oywv8DBIAbxf1eOiJ5X5vpDnICqa+k6nGcB9h8g86I/UBGVvENct1dpk2MK8G Mtk0eD9DIcBsWPa+J4syRxahaxu+bZctlly+Je2GyJoDJHh1kJM4D8tvR9FCAsam 0QyvRJyqT5pH7eYWwypuw3quKE85zExCjTLmbk9J1hdNQErVCIrf/Pz9YHqxDqMd eNQVuOhhtWTs81VnrYm19+PnmxyU9l2zKpVBZyYtpwNMVqJbHEFoYw2u7KqRcGOp HcDl8rCwV2zckdL0eYgmmJWcd82ep1GLoMC6nbsWkMcZDXRsmNd/7aPwL+IrRUtg ZGG6rhd5LqNsr6Fncgkije+g08Kv36XZkHNE9TkAKs6+JeGTTJ7L/Vy7CY7KAvhN hFH3ukznAKZE3ukLhN5f3ucWT2xXu4r3keGxWS+gKYGgObJclkhnB3SrSUHBqtyX yTWTyaqJzyZfxh1S1HO/feitFL24Jl/IBYlN02IHDsHTdPMwIF0kvKcNOHgT8FCh 2vvvxAAt =yT79 -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170823154922.GA47318>