From owner-cvs-all Thu Jan 16 9:53:49 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1FCE437B401 for ; Thu, 16 Jan 2003 09:53:48 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id AB38E43F18 for ; Thu, 16 Jan 2003 09:53:46 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 46906 invoked by uid 1000); 16 Jan 2003 17:53:47 -0000 Date: Thu, 16 Jan 2003 09:53:47 -0800 (PST) From: Nate Lawson To: Martin Blapp Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: src/usr.sbin/mountd mountd.c src/usr.sbin/rpc.lockd lockd.c src/usr.sbin/rpc.statd statd.c src/usr.sbin/rpc.yppasswdd yppasswdd_main.c src/usr.sbin/rpcbind rpcb_svc_com.c rpcbind.c src/usr.bin/rpcgen rpc_main.c rpc_svcout.c In-Reply-To: <20030116072738.00CC737B423@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 15 Jan 2003, Martin Blapp wrote: > Modified files: > usr.sbin/mountd mountd.c > usr.sbin/rpc.lockd lockd.c > usr.sbin/rpc.statd statd.c > usr.sbin/rpc.yppasswdd yppasswdd_main.c > usr.sbin/rpcbind rpcb_svc_com.c rpcbind.c > usr.bin/rpcgen rpc_main.c rpc_svcout.c > Log: > Implement nonblocking tpc-connections. rpcgen -m does still > produce backcompatible code. > > Reviewed by: rwatson > Obtained from: NetBSD > MFC after: 1 day This looks interesting. Please use a longer MFC period than 1 day for something which touches a major library component and many user programs. In particular, changes like this could use testing: > - switch (poll_ret = poll(pollfds, nfds, INFTIM)) { > + switch (poll_ret = poll(pollfds, nfds, 30 * 1000)) { I'm sure it works fine on NetBSD but there are always subtle interactions. IMO, a 1 day MFC should only be used for man pages or whitespace changes or things which should only have a compile-time effect. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message