From owner-freebsd-current@FreeBSD.ORG Mon Aug 1 04:33:35 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DADE16A429 for ; Mon, 1 Aug 2005 04:33:35 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2716143D46 for ; Mon, 1 Aug 2005 04:33:35 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j714UwOo099791; Sun, 31 Jul 2005 22:31:03 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 31 Jul 2005 22:31:49 -0600 (MDT) Message-Id: <20050731.223149.128656550.imp@bsdimp.com> To: sam@errno.com From: "M. Warner Losh" In-Reply-To: <42ED06D8.70506@errno.com> References: <20050731142625.GC1190@unixpages.org> <42ED06D8.70506@errno.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: [PATCH] fwip(4) panic on attach X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2005 04:33:35 -0000 In message: <42ED06D8.70506@errno.com> Sam Leffler writes: : Christian Brueffer wrote: : > - bzero(fwip, sizeof(struct fwip_softc)); : I thought the softc was guaranteed to be zero'd; can't you just delete : the bzero? Yes. Softc is allocated zero'd. Warner