Date: Fri, 15 Feb 2019 18:41:53 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 235762] USE_GITHUB=nodefault breaks default DISTFILES Message-ID: <bug-235762-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235762 Bug ID: 235762 Summary: USE_GITHUB=3Dnodefault breaks default DISTFILES Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: jhb@FreeBSD.org CC: ports-bugs@FreeBSD.org In https://reviews.freebsd.org/D19087 I added an optional patchset to an existing port. The main distfile for the port is fetched via ftp/http, but= the patchset comes from GitHub. As such, I used USE_GITHUB=3Dnodefault so that= it would only be used for the optional patchset. However, when I did that, DISTFILES was set to only include the patchset from GitHub and did not incl= ude the "default" DISTFILES setting for the main distfile. I had to explicitly= set DISTFILES to the default value as a workaround. I'm not sure if this is fixable? Maybe when USE_GITHUB sets DISTFILES it could include the default DISTFILES value in the "nodefault" case if DISTFILES isn't already defined? Looking at other ports using USE_GITHUB=3Dnodefault, it seems like the foll= owing ports use the same workaround: audio/x42-plugins-lv2 lang/dmd2 databases/mantis graphics/vkd3d math/py-pynleq2 net/wireguard-go (uses a DISTFILES that is effectively the default) security/obfs4proxy-tor sysutils/tmux sysutils/tmux23 www/nginx www/nginx-devel On the other hand, it seems like the following ports depend on the current behavior and only have non default distfiles from GitHub. It's not clear t= o me why they need to use 'nodefault' vs just 'yes' in that case? devel/abi-compliance-checker games/redeclipse-data lang/dmd2 One I'm not sure about is dns/amass. It says it only uses nodefault to avo= id a circular dependency? One more special case is science/dalton which uses GitLab for the default distfile. Finally, www/kurly uses both USE_GITLAB=3Dnodefault and USE_GITHUB=3Dnodefa= ult and doesn't have a default distfile at all. I think it would be nice if "nodefault" kept the default DISTFILES setting = if DISTFILES wasn't explicitly set by the Makefile (and perhaps a port could s= et it to empty when it has no default distfiles), but if that's too hard to fi= x, then perhaps update the docs to note this? When I was reading the section = on fetching distfiles from GitHub and nodefault, I had assumed it would preser= ve the default behavior for the default DISTFILES rather than requiring DISTFI= LES to be explicitly set. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-235762-7788>