Date: Fri, 23 Jul 2010 16:31:15 +0200 (CEST) From: Daniel Gerzo <danger@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/148867: [patch] net-p2p/dcd - set the correct signal for sig_stop Message-ID: <201007231431.o6NEVFq0094292@alice.syscare.sk> Resent-Message-ID: <201007231440.o6NEe3vk057853@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 148867
>Category: ports
>Synopsis: [patch] net-p2p/dcd - set the correct signal for sig_stop
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Fri Jul 23 14:40:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Daniel Gerzo
>Release: FreeBSD 8.0-STABLE amd64
>Organization:
SysCare s. r. o.
>Environment:
>Description:
in /etc/rc.subr, we have _run_rc_killcmd() function, which does this:
_cmd="kill -$1 $rc_pid".
When we set sig_stop to -KILL, the kill command receives wrong signal
(i.e. "--KILL") so it silently sends a wrong signal.
>How-To-Repeat:
>Fix:
--- dcd.sh.in.diff begins here ---
--- dcd.sh.in.orig 2010-07-23 16:26:44.089552994 +0200
+++ dcd.sh.in 2010-07-23 16:26:58.105356378 +0200
@@ -16,7 +16,7 @@
rcvar=${name}_enable
command=%%PREFIX%%/sbin/dcd
-sig_stop=-KILL
+sig_stop=KILL
stop_cmd=stop_cmd
load_rc_config $name
--- dcd.sh.in.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007231431.o6NEVFq0094292>