From owner-cvs-all@FreeBSD.ORG Thu Apr 24 17:52:25 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1374C37B401; Thu, 24 Apr 2003 17:52:25 -0700 (PDT) Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id 00AA143FCB; Thu, 24 Apr 2003 17:52:22 -0700 (PDT) (envelope-from nectar@celabo.org) Received: from madman.celabo.org (madman.celabo.org [10.0.1.111]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "madman.celabo.org", Issuer "celabo.org CA" (verified OK)) by gw.nectar.cc (Postfix) with ESMTP id 5BA664D; Thu, 24 Apr 2003 19:52:21 -0500 (CDT) Received: by madman.celabo.org (Postfix, from userid 1001) id A66B578C66; Thu, 24 Apr 2003 19:52:20 -0500 (CDT) Date: Thu, 24 Apr 2003 19:52:20 -0500 From: "Jacques A. Vidrine" To: Juli Mallett Message-ID: <20030425005220.GB23638@madman.celabo.org> References: <200303030940.h239eWGY061182@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200303030940.h239eWGY061182@repoman.freebsd.org> X-Url: http://www.celabo.org/ User-Agent: Mutt/1.5.3i-ja.1 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/fsck fsck.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2003 00:52:25 -0000 On Mon, Mar 03, 2003 at 01:40:32AM -0800, Juli Mallett wrote: > jmallett 2003/03/03 01:40:32 PST > > FreeBSD src repository > > Modified files: > sbin/fsck fsck.c > Log: > Strip out bogus difference from when this came from NetBSD: transliterating > upper-case alphabetical characters to lower-case ones, and spaces to dashes. > The person who added this when bringing the code from NetBSD has no idea why > he added it, and nobody on freebsd-fs came up with any cases where the icky > part (the conversion of spaces to underscores) was needed. The removal of > the upper-case conversion follows an even more obvious logic: it avoids any > sort of namespace issues. People using StUdLy caps for filesystem names > deserve everything they get. Otherwise, Efs and efs might be totally different > things, but would use the same fsck. And we don't want that, right? That > just provokes the sort of foot-shooting this would prevent. > > If you have problems with this, I'll walk you through using sed on your fstab, > cause the only way you could have problems is if you spelled ufs as "UFS". > Most likely, you haven't done that. > > MFC after: 1 month > > Revision Changes Path > 1.13 +1 -17 src/sbin/fsck/fsck.c Hi Juli, Please back this out. If there is no fstab, the vfstype is retrieved from the disklabel. It will likely be `4.2BSD', and fsck will try to find /sbin/fsck_4.2BSD and fail. Look at `FS_BSDFFS' and `fstypenames[]' in sys/disklabel.h to see what I mean. (A failure of this sort was just reported to me by a coworker.) And please don't remove any more code just because you don't know why it is there. K PLZ THX :-) Cheers, -- Jacques A. Vidrine http://www.celabo.org/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se