From nobody Wed Apr 29 14:48:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g5KtQ3R0kz6bkY1 for ; Wed, 29 Apr 2026 14:48:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g5KtP6Xkdz4K3C for ; Wed, 29 Apr 2026 14:48:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777474109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xlF7RIgB+4UxJF6hci6bgteZeNJigGDW3bCzYXAori4=; b=pvxRgpFlkweishoo0eKIBRxKLNcFV35flT0amrilAZ/cU+mVlnrtBqlVImqqyKaPT8u6RS 2mQi5QP17ZKsDys8lBhdNO44HFOh8VqA5vw9Wg2iyy50vmQCN8JqOjvWHopvLesMZCGDNo lT/SKlIIeYfuhlMNuF3nigwDNkoSkADx+sHT1ACEzvOn4QIMb6lbwERewgOAVwKTYN5PVy 05LJFsDxLq5jpAnsmI3jHFakHpnNlUx5LgO7HgPNSTceWveEbVkjw90BiLRujjHHyO58Wt 24JpB9UxQ0Vep6DWafgXxxn7JIgUHK8aUwrVKd3krNoHY1q6IkNrV4zb0psZ9g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777474109; a=rsa-sha256; cv=none; b=lnWSk3/HLtlU7EYbhzoPGTqRvq8/gE00SQwq9ZLRyFu7Tota1bPXuOfhWdU+XAnULU9ecP SWGkAqmjnCvGcG00IbKhd2YWXqdbBnlfToMt7Hyz+zhPh96LsbXXuj3ZSY4jZxE0E3oTbp b0icpSsk5z4rI00wrE1+h/8Q8Zr/OwoenAHQ/ZmlgyHpDePoh9AETrf8DwNBn2UYEUfOZR DF9V0NuazguYHOdLbdjmWALsz++tX2r7/Bjm3su902yQAT0ysNOhpUdkQxRBM+I4EQUXB3 32tiCYIdIOPac8ziCCP985+bSUWtVFDG/oUecdA3t83WK6O6g8FDHSyoXFzaiQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777474109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xlF7RIgB+4UxJF6hci6bgteZeNJigGDW3bCzYXAori4=; b=VdDhbLbCERlAppyj/DbBMY8aJFAbWQlriYKD5lkPFyDhOdZori8pyidUe33OcnjyhaTti5 rTWwtA1/4KM2zByIrdPKBrTsBSutvPFPO3OYaCUz2zlEOvov3f2CSdabyF22QLVDmgcQgt vzFB/FmY+pNDrjzCA3ugnBGkvkIa+g/vGd8jaJtYCyNv/FpkhOesxsuEdmrb7uNyxEYzHo dE8snnMveHBG4f7dHXxvI5xjN6kL5H+zK45ohmxhwtj11Hn6xNBhcRyEi8ndly4ZmjusAu L07m4z7aSsCJkgl7sQJA/NnaxgPKKYLY7N+uzQw+WzohcNMs11Zq6BLrurNrQw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g5KtP63pFzlbP for ; Wed, 29 Apr 2026 14:48:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c89b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Apr 2026 14:48:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 66d6c32ce7b8 - releng/15.0 - dhclient: Fix reallocation of dhclient script environments List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.0 X-Git-Reftype: branch X-Git-Commit: 66d6c32ce7b84172e4c6069ce3acf8f5c422d1fa Auto-Submitted: auto-generated Date: Wed, 29 Apr 2026 14:48:29 +0000 Message-Id: <69f21a3d.3c89b.617f94d5@gitrepo.freebsd.org> The branch releng/15.0 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=66d6c32ce7b84172e4c6069ce3acf8f5c422d1fa commit 66d6c32ce7b84172e4c6069ce3acf8f5c422d1fa Author: Mark Johnston AuthorDate: 2026-04-27 20:56:21 +0000 Commit: Mark Johnston CommitDate: 2026-04-28 19:27:11 +0000 dhclient: Fix reallocation of dhclient script environments When the number of DHCP options exceeds a threshold, script_set_env() will reallocate the environment, stored as an array of pointers. The calculation of the array size failed to multiply by the pointer size, resulting in a smaller than expected buffer which admits out-of-bounds writes. Approved by: so Security: FreeBSD-SA-26:15.dhclient Security: CVE-2026-42511 Reported by: Joshua Rogers of AISLE Research Team (https://aisle.com/) --- sbin/dhclient/dhclient.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/dhclient/dhclient.c b/sbin/dhclient/dhclient.c index 719e20cffad9..f671b0ab9bed 100644 --- a/sbin/dhclient/dhclient.c +++ b/sbin/dhclient/dhclient.c @@ -2438,8 +2438,8 @@ script_set_env(struct client_state *client, const char *prefix, char **newscriptEnv; int newscriptEnvsize = client->scriptEnvsize + 50; - newscriptEnv = realloc(client->scriptEnv, - newscriptEnvsize); + newscriptEnv = reallocarray(client->scriptEnv, + newscriptEnvsize, sizeof(char *)); if (newscriptEnv == NULL) { free(client->scriptEnv); client->scriptEnv = NULL;