Date: Fri, 27 Feb 2015 08:56:00 -0700 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Ed Maste <emaste@FreeBSD.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Andrew Turner <andrew@fubar.geek.nz>, Bruce Evans <brde@optusnet.com.au>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r279349 - head/sys/kern Message-ID: <1425052560.1281.21.camel@freebsd.org> In-Reply-To: <E4396923-9EAD-4FFA-82B9-6831B385CA8E@bsdimp.com> References: <201502270256.t1R2uxnv085328@svn.freebsd.org> <20150227082257.3fb1081c@bender.Home> <20150227202646.I2088@besplex.bde.org> <CAJ5_RoCj_D06WK%2BUVrLXNouu252X-6oaaj68RJoQhDzx_wJyAA@mail.gmail.com> <CAPyFy2AwRzvksD_5EcEU5EEvzR7tB1FOpAYzWc2nLtCnyGzaRQ@mail.gmail.com> <E4396923-9EAD-4FFA-82B9-6831B385CA8E@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2015-02-27 at 08:46 -0700, Warner Losh wrote: > Sure wish my code review got this much love… > > Warner > IMO, the biggest problem with phab reviews is advertising them. You can guess who might be interested and add them as reviewers. You can try posting a summary and the url to some mailing list. I wonder if it would be useful to have the system itself mail the summary line of every new review that's created to some list? It would probably need to be several lists -- I sure don't want to see every ports phab that gets created, but getting a single mail for every src review created wouldn't be too much. I don't know if that's a good idea or not, but the reason we reliably get post-commit reviews is because the changes reliably appear in front of everyone's eyes at that point. -- Ian > > On Feb 27, 2015, at 8:30 AM, Ed Maste <emaste@FreeBSD.org> wrote: > > > > On 27 February 2015 at 10:12, Benjamin Kaduk <bjkfbsd@gmail.com> wrote: > >> > >> As of r278229, the kernel is compiled with -fwrapv, so signed integer > >> overflow in the FreeBSD kernel is defined behavior. > > > > This is primarily a workaround to accommodate existing code though; > > it's not a result of an explicit decision that we want to support > > signed integer overflow. > > > > -Ed > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1425052560.1281.21.camel>