Date: Thu, 8 Dec 2011 00:16:49 -0600 From: Zhihao Yuan <lichray@gmail.com> To: freebsd-hackers@freebsd.org Subject: Re: [nvi-iconv]Call for test Message-ID: <CAGsORuDbJFujas2=pfiwcV_OV_d-VKDa6hR=N7BA4=Pgvmm5fQ@mail.gmail.com> In-Reply-To: <CAGsORuAqu0fyHAq9Tc1%2ByF2C_X=iG4QjYosXJUFthtJFO%2BSH5w@mail.gmail.com> References: <CAGsORuBr=b-cJEAJO7cJ=j5dn04kJfR%2BHzz58Rjc29uTDZv4Xg@mail.gmail.com> <CAGsORuCsz_XzWntZ_y40SuAS%2B7saT7GzMUoTzpGgdCN5aTYuNg@mail.gmail.com> <868vqt0xuc.fsf@gmail.com> <CAGsORuDiq%2BgsGyV1Da0mUKj0JBnam584S2z5VFVcKyKM1qsVdw@mail.gmail.com> <1313663436600-4711635.post@n5.nabble.com> <86hb5euofp.fsf@gmail.com> <CAGsORuBJsP6AuB_biHJ9wv55=qhkb%2BWRQLpMUBkgA_OXuXKCbA@mail.gmail.com> <20110823175133.GK18091@acme.spoerlein.net> <CAGsORuCNJwwj9stHqMKS=1y8hd7Zga=V1zQ0EsHJCdryy0B3gw@mail.gmail.com> <CAGsORuD53dBXmRi3LQMAsrVy4FL11L6r9ZX2NONptWeDZMaySQ@mail.gmail.com> <CAGsORuAqu0fyHAq9Tc1%2ByF2C_X=iG4QjYosXJUFthtJFO%2BSH5w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, I uploaded a new version, 2.0.2. http://students.cs.niu.edu/~z1565938/distfiles/nvi2-freebsd-2011-12-07.diff.gz Same as before, you need to remove usr.bin/vi/port.h after you applied this patch. In this version, I analyzed all of the PRs, patches/commits of Debian's nvi package and NetBSD's nvi-1.81.6b5 in base. Many bug fixes are merged. And 2 main features are gained: 1. Recognized non-ASCII letters' upper/lower cases (~); 2. Recognized non-ASCII word boundary (w, ^A, regex, etc.). Btw, vim don't have such features. I also solved all memory leak in all know tests. iconv_open(3) usage part is rewrote. 2 changes from NetBSD are not merged: 1. To use signed char instead of unsigned char in 8-bit mode. This requires to cast all character to at least unsigned char when passing them to ctype(3). Test cases are required to convince me on this part; 2. 32-bit clean regex. According to the PRs and commit log, I don't have enough confidence in NetBSD's code here. Although the current regex in use is only 24-bit clean, but it works correctly and, my final solution is to use TRE in base directly. Comments and test reports are welcome. -- Zhihao Yuan, nickname lichray The best way to predict the future is to invent it. ___________________________________________________ 4BSD -- http://4bsd.biz/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGsORuDbJFujas2=pfiwcV_OV_d-VKDa6hR=N7BA4=Pgvmm5fQ>