From owner-cvs-src@FreeBSD.ORG Sun Jan 29 21:45:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 01FAB16A420; Sun, 29 Jan 2006 21:45:54 +0000 (GMT) (envelope-from emaste@phaedrus.sandvine.ca) Received: from mailserver.sandvine.com (sandvine.com [199.243.201.138]) by mx1.FreeBSD.org (Postfix) with ESMTP id 84A5B43D46; Sun, 29 Jan 2006 21:45:51 +0000 (GMT) (envelope-from emaste@phaedrus.sandvine.ca) Received: from labgw2.phaedrus.sandvine.com ([192.168.3.11]) by mailserver.sandvine.com with Microsoft SMTPSVC(5.0.2195.6713); Sun, 29 Jan 2006 16:44:25 -0500 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 12627) id 3CCE41365D; Sun, 29 Jan 2006 16:45:50 -0500 (EST) Date: Sun, 29 Jan 2006 16:45:50 -0500 From: Ed Maste To: Julian Elischer Message-ID: <20060129214549.GA10331@sandvine.com> References: <200601291539.k0TFd93N068882@repoman.freebsd.org> <43DD2555.8080408@elischer.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43DD2555.8080408@elischer.org> User-Agent: Mutt/1.4.2.1i X-OriginalArrivalTime: 29 Jan 2006 21:44:26.0000 (UTC) FILETIME=[2CA61900:01C6251D] Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ed Maste , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ath if_ath.c src/sys/dev/awi awi.c src/sys/dev/bfe if_bfe.c src/sys/dev/bge if_bge.c src/sys/dev/ed if_ed.c src/sys/dev/em if_em.c src/sys/dev/ex if_ex.c src/sys/dev/fe if_fe.c src/sys/dev/fxp if_fxp.c src/sys/dev/gem ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2006 21:45:54 -0000 On Sun, Jan 29, 2006 at 12:28:05PM -0800, Julian Elischer wrote: > Ed Maste wrote: > > >emaste 2006-01-29 15:39:09 UTC > > Note that with these changes, these drivers now depend on locking the > > global > > if_addr_mtx, so binary modules of these drivers will not work on 5.4 or > > earlier releases. > > > > > > Is the converse true? > > i.e. can older binaries (e.g. from 5.4) work on 5.5? > > this is a "must" Robert's answer pretty much covers everything, and I also posted that same info (that older binaries will continue to work) to -STABLE. Also, I did the MFC in three parts, making sure everything continued to work as I went. That is, until this commit, the drivers did not lock the new mutex, and thus functioned exactly as old binary modules would on 5.5. The only thing I suppose I should add is that anyone contemplating releasing binary-only driver modules for FreeBSD 5.x will need to avoid locking this mutex in order to make the module work on all 5.x releases. -ed