From owner-svn-src-all@freebsd.org  Wed May  4 13:49:00 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7C5FB2C27A;
 Wed,  4 May 2016 13:49:00 +0000 (UTC)
 (envelope-from royger@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B8487198F;
 Wed,  4 May 2016 13:49:00 +0000 (UTC)
 (envelope-from royger@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u44Dmxp5092689;
 Wed, 4 May 2016 13:48:59 GMT (envelope-from royger@FreeBSD.org)
Received: (from royger@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u44Dmxd0092688;
 Wed, 4 May 2016 13:48:59 GMT (envelope-from royger@FreeBSD.org)
Message-Id: <201605041348.u44Dmxd0092688@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: royger set sender to
 royger@FreeBSD.org using -f
From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <royger@FreeBSD.org>
Date: Wed, 4 May 2016 13:48:59 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r299064 - head/sys/kern
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2016 13:49:01 -0000

Author: royger
Date: Wed May  4 13:48:59 2016
New Revision: 299064
URL: https://svnweb.freebsd.org/changeset/base/299064

Log:
  rtc: fix inverted resolution check
  
  The current code in clock_register checks if the newly added clock has a
  resolution value higher than the current one in order to make it the
  default, which is wrong. Clocks with a lower resolution value should be
  better than ones with a higher resolution value, in fact with the current
  code FreeBSD is always selecting the worse clock.
  
  Reviewed by:		kib jhb jkim
  Sponsored by:		Citrix Systems R&D
  MFC after:		2 weeks
  Differential revision:	https://reviews.freebsd.org/D6185

Modified:
  head/sys/kern/subr_rtc.c

Modified: head/sys/kern/subr_rtc.c
==============================================================================
--- head/sys/kern/subr_rtc.c	Wed May  4 12:51:27 2016	(r299063)
+++ head/sys/kern/subr_rtc.c	Wed May  4 13:48:59 2016	(r299064)
@@ -84,7 +84,7 @@ clock_register(device_t dev, long res)	/
 {
 
 	if (clock_dev != NULL) {
-		if (clock_res > res) {
+		if (clock_res <= res) {
 			if (bootverbose)
 				device_printf(dev, "not installed as "
 				    "time-of-day clock: clock %s has higher "