From owner-freebsd-ports@FreeBSD.ORG  Mon Aug 21 23:35:45 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 27DAF16A4DA
	for <ports@freebsd.org>; Mon, 21 Aug 2006 23:35:45 +0000 (UTC)
	(envelope-from timur@com.bat.ru)
Received: from mail.bat.ru (dzokonda.xs4all.nl [194.109.164.75])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1246543D73
	for <ports@freebsd.org>; Mon, 21 Aug 2006 23:35:36 +0000 (GMT)
	(envelope-from timur@com.bat.ru)
Received: from timur.home.bat.ru ([192.168.0.4] verified)
	by mail.bat.ru (CommuniGate Pro SMTP 4.2.7)
	with ESMTP-TLS id 1143840; Tue, 22 Aug 2006 01:35:50 +0200
Received: (from timur@localhost)
	by timur.home.bat.ru (8.13.6/8.13.6/Submit) id k7LNZXtv003069;
	Tue, 22 Aug 2006 01:35:33 +0200 (CEST) (envelope-from timur)
Date: Tue, 22 Aug 2006 01:35:33 +0200
From: "Timur I. Bakeyev" <timur@gnu.org>
To: Bill Blue <bblue@controlroom.net>, Rainer Alves <rainer.alves@gmail.com>, 
	ports@freebsd.org, timur@gnu.org
Message-ID: <20060821233533.GA1487@com.bat.ru>
References: <44DE1656.1020803@rogers.com> <44DE1CFD.4010204@gmail.com>
	<op.td6pbgxmr2360o@v2.netoldies.com>
	<20060816192525.GA1167@roadrunner.buck.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060816192525.GA1167@roadrunner.buck.local>
User-Agent: mutt-ng/devel-r581 (FreeBSD)
Cc: 
Subject: Re: FreeBSD Port: net/samba3 (rc.d weirdness)
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Aug 2006 23:35:45 -0000

Hi, Ulrich!

On Wed, Aug 16, 2006 at 09:25:26PM +0200, Ulrich Spoerlein wrote:
> 
> The function "checkyesno" cannot handle undefined variables and will
> thus print an error. This will happen ON EVERY machine that samba3 is
> installed, but there is no samba_enable="YES/NO" line in rc.conf.
> 
> The quick fix is to alter the samba script to set a default value (to
> NO), just like almost every other port does, eg., run
> 
> $ egrep '_enable:?-"?NO' /usr/local/etc/rc.d/*
> 
> 010.pgsql.sh:postgresql_enable=${postgresql_enable:-"NO"}
> privoxy:privoxy_enable=${privoxy_enable-"NO"}
> snmpd:snmpd_enable=${snmpd_enable-"NO"}
> symon:symon_enable=${symon_enable:-"NO"}
> 
> I'll CC the maintainer ...

Thanks for pointing me out on this flaw. IIRC, when I first wrote this
script it did work ok. So, seems, something got broken since then.

I'll try to push the changes ASAP, together with some other minor fixes
to the port.

With best regards,
Timur Bakeyev.