From owner-svn-src-head@FreeBSD.ORG Sat Dec 17 22:00:46 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA5F41065672; Sat, 17 Dec 2011 22:00:46 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) by mx1.freebsd.org (Postfix) with ESMTP id 602BF8FC14; Sat, 17 Dec 2011 22:00:46 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 2E1F025D3811; Sat, 17 Dec 2011 22:00:45 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id A0D31BD737E; Sat, 17 Dec 2011 22:00:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id Kep92r6iOgSW; Sat, 17 Dec 2011 22:00:43 +0000 (UTC) Received: from orange-en1.sbone.de (orange-en1.sbone.de [IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id F2FB2BD737D; Sat, 17 Dec 2011 22:00:42 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Bjoern A. Zeeb" In-Reply-To: <4EED109B.9020104@FreeBSD.org> Date: Sat, 17 Dec 2011 22:00:42 +0000 Content-Transfer-Encoding: 7bit Message-Id: References: <201112171721.pBHHLloU069166@svn.freebsd.org> <4C98B8D8-99F6-4996-A0FB-C128D9384180@lists.zabbadoz.net> <4EED109B.9020104@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228650 - head/usr.bin/netstat X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 22:00:46 -0000 On 17. Dec 2011, at 21:58 , Dimitry Andric wrote: > On 2011-12-17 22:53, Bjoern A. Zeeb wrote: >> >> On 17. Dec 2011, at 17:21 , Dimitry Andric wrote: >> >>> Author: dim >>> Date: Sat Dec 17 17:21:47 2011 >>> New Revision: 228650 >>> URL: http://svn.freebsd.org/changeset/base/228650 >>> >>> Log: >>> In usr.bin/netstat/atalk.c, work around a clang false positive with >>> printf format warnings and conditional operators. >>> >> >> This does not sound like a good idea. Make clang work. > > It's already being worked on, see: > > http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-November/018464.html > > and: > > http://llvm.org/bugs/show_bug.cgi?id=11313 > > Meanwhile, this is just a temporary workaround. If you think it is too > disruptive, I can just add NO_WFORMAT to the Makefile instead. I'd prefer we do not start mangling source code for things that are not a problem with the code and just a problem with the warning level. Especially if the change will not be required anymore in the future. A Makefile option we can easily identify and grep for, a cast we just forget. /bz -- Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family.