Date: Sat, 12 Jun 2004 14:45:28 +0200 (CEST) From: Markus Wild <mwild@vianetworks.ch> To: Anish Mistry <mistry.7@osu.edu> Cc: freebsd-hardware@freebsd.org Subject: Re: Fix for Logitech DiNovo cordless mouse [PATCH] Message-ID: <200406121245.i5CCjTOZ011659@smsgw.vianetworks.ch> In-Reply-To: <200406111703.14772.mistry.7@osu.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Hm, I had a look through the patched files, and one thing that sprung to my eyes: the FreeBSD hid_report_size(() function is currently used to both return the size of a report, as well as setting the device report ID (the ID parameter is of type "out"). This ID is later used to match incoming reports to the device. With the suggested changes, this parameter changes to being of type "in", i.e. the function no longer returns the ID information to the calling function. This would certainly generate a compile time warning (if not error) for ums.c, and while uhid.c has been syntactically changed, I now see no place where sc->sc_iid, sc->sc_oid, sc->sc_fid would be initialized after applying the change. I assume the NetBSD code in itself is sound, so perhaps we're just missing additional files now that would also need to be changed for FreeBSD? Cheers, Markus
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406121245.i5CCjTOZ011659>