From owner-svn-src-all@FreeBSD.ORG Tue Jun 9 18:24:34 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFF7C10656BA; Tue, 9 Jun 2009 18:24:34 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 79B9F8FC2C; Tue, 9 Jun 2009 18:24:34 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.local (pooker.samsco.org [168.103.85.57]) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id n59IOVNj097645; Tue, 9 Jun 2009 12:24:31 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4A2EA8DE.2080105@samsco.org> Date: Tue, 09 Jun 2009 12:24:30 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Sam Leffler References: <200904190016.n3J0G4rA090911@svn.freebsd.org> <20090609143729.R22887@maildrop.int.zabbadoz.net> <3c1674c90906091012u26b0e823q57a7ea1f42eef22d@mail.gmail.com> <4A2E9994.7070907@freebsd.org> In-Reply-To: <4A2E9994.7070907@freebsd.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=3.8 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, "Bjoern A. Zeeb" , Kip Macy , src-committers@FreeBSD.org Subject: Re: svn commit: r191255 - in head/sys: amd64/conf conf i386/conf net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 18:24:35 -0000 Sam Leffler wrote: > Kip Macy wrote: >>> I think FLOWTABLE does nto belong into DEFAULTS. Really DEFAULTS was >>> meant for "You cannot boot without this" and if people start to weaken >>> it, DEFAULTS will soon be the new GENERIC. That said I am not sure it >>> belongs to GENERIC either. >>> >> >> I can either push it in to GENERIC or I can change it to NOFLOWTABLE. >> If you want to remove it from GENERIC then we're going to have to have >> a lengthy discussion about what most FreeBSD users actually use and >> gut GENERIC as it stands now. The fact is, most FreeBSD users have >> sufficiently few peers that flowtable is a win over using the routing >> table on every lookup. >> > > I believe the question was mainly about mechanics, FLOWTABLE doesn't > belong in DEFAULTS but it may well belong in GENERIC. > > Sam > If you want it to be an opt-out feature, wrap the code in #ifndef DISABLE_FLOWTABLE. I agree that what was put into DEFAULTS is inappropriate for what DEFAULTS was meant to do. Scott