From owner-cvs-all Sun Oct 10 2:16:45 1999 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 5936214DDA; Sun, 10 Oct 1999 02:16:39 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id LAA14182; Sun, 10 Oct 1999 11:15:54 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Sheldon Hearn Cc: Chris Piazza , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 In-reply-to: Your message of "Sun, 10 Oct 1999 11:12:58 +0200." <73957.939546778@axl.noc.iafrica.com> Date: Sun, 10 Oct 1999 11:15:54 +0200 Message-ID: <14180.939546954@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In message <73957.939546778@axl.noc.iafrica.com>, Sheldon Hearn writes: > > >On Sun, 10 Oct 1999 02:04:21 MST, Chris Piazza wrote: > >> > (p = f()) == NULL) >> >> Hmm, you're right I guess. I was reading it as if(... >> >> Should I revert this or change it? > >Changing it and the example below it to if statements would probably >make the fragments more consistent with other examples of tests in the >style.9 manpage. Whatever you do, just make sure you end up with a >consistent style at the end of the day. ;-) Apart from the fact that we discourage assignments inside if (...) -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message