From owner-cvs-all@FreeBSD.ORG  Thu Mar 20 08:44:22 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6083D1065671;
	Thu, 20 Mar 2008 08:44:22 +0000 (UTC) (envelope-from dfr@rabson.org)
Received: from anchor-post-34.mail.demon.net (anchor-post-34.mail.demon.net
	[194.217.242.92])
	by mx1.freebsd.org (Postfix) with ESMTP id D62D28FC24;
	Thu, 20 Mar 2008 08:44:21 +0000 (UTC) (envelope-from dfr@rabson.org)
Received: from router.rabson.org ([80.177.232.241] helo=itchy.rabson.org)
	by anchor-post-34.mail.demon.net with esmtp (Exim 4.67)
	id 1JcGNo-000Hb9-DW; Thu, 20 Mar 2008 08:44:20 +0000
Received: from macbook.rabson.org (macbook.rabson.org
	[IPv6:2002:50b1:e8f2:1:21e:52ff:fe73:8011])
	by itchy.rabson.org (Postfix) with ESMTP id C2CC93FAC;
	Thu, 20 Mar 2008 08:44:19 +0000 (GMT)
Message-Id: <F042E351-95A3-4C9A-92AF-878CB0F93EBE@rabson.org>
From: Doug Rabson <dfr@rabson.org>
To: Alfred Perlstein <alfred@freebsd.org>
In-Reply-To: <20080320025645.GI67856@elvis.mu.org>
Content-Type: multipart/signed; boundary=Apple-Mail-62-62192841; micalg=sha1;
	protocol="application/pkcs7-signature"
Mime-Version: 1.0 (Apple Message framework v919.2)
Date: Thu, 20 Mar 2008 08:44:19 +0000
References: <200803191233.m2JCXPRp070753@repoman.freebsd.org>
	<20080320025645.GI67856@elvis.mu.org>
X-Mailer: Apple Mail (2.919.2)
X-Virus-Scanned: ClamAV 0.92/6310/Thu Mar 20 06:02:00 2008 on itchy.rabson.org
X-Virus-Status: Clean
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: cvs-src@FreeBSD.org, Doug Rabson <dfr@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfsserver nfs_srvsock.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Mar 2008 08:44:22 -0000


--Apple-Mail-62-62192841
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit


On 20 Mar 2008, at 02:56, Alfred Perlstein wrote:

> * Doug Rabson <dfr@FreeBSD.org> [080319 05:32] wrote:
>> dfr         2008-03-19 12:33:25 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/nfsserver        nfs_srvsock.c
>>  Log:
>>  Fix a regression from the last revision - don't edit the ns_rec  
>> list while
>>  not holding the lock.
>>
>>  Revision  Changes    Path
>>  1.107     +3 -1      src/sys/nfsserver/nfs_srvsock.c
>
> This function should have a WITNESS check at the top of it.
>
> Can you add it?  If not I will unless you see a problem with
> it.

The various WITNESS_* macros appear to be undocumented and I'm not  
sure what they do. Perhaps it would be best if you added something.


--Apple-Mail-62-62192841--