From owner-svn-src-all@freebsd.org Sat Sep 7 14:50:39 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E267BD4655; Sat, 7 Sep 2019 14:50:39 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Qcmb00Dvz4dct; Sat, 7 Sep 2019 14:50:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x734.google.com with SMTP id q203so8637753qke.1; Sat, 07 Sep 2019 07:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Qk5K7FRdR/NyeX6dhjayWlWV4L/WTQ24Fax8wbwoHc8=; b=VQmjzVSLVHxQvAobykOKigEicdDsSO3OCmi4EYlJx+upLhOo3xfX++25lL9AkovOH5 DogmB7fJp9tR4QqwMMU9V1zKZkycGpMCAj7lwpB5mYQGn2XJnOaYEw0y0yMvgb7s7/Ly pb/ynz53s0AksfCWH8wd4+us+dtkzKE948LRvFGrJ18T94auDvoIGpr/EEfZll541WD5 7Q0lxeH64uOKcsxeTNh6NntxLV6hMaoyIIJlK5wwfjpjXNbhZpZVhbiYm8HG+hpnI0e5 gxJjj+E+CSAHjo/axZHyOKjbwnUJ2e92PO/dB5mBKv4oYZJIT1kt+ZIgzRf8jQCHvou+ kc4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Qk5K7FRdR/NyeX6dhjayWlWV4L/WTQ24Fax8wbwoHc8=; b=ffxFF6rMimYjE1SVKu8Khp1q7u50Se5Ms8IsqBOe+KF+roNV0WMdbPb52zstfjfb/F 8R0307Rgm429BkvMGwkcoIheYnsUKZp3KFUcTP5GwWCcexe4/lOkP5u6nzTEUn+MIofN 3tdlWEp2PbGDN2go6t3HzFQahGtCOGMhyYR+Ib1FYk2U4pmtR8tx8kMBj+UzHXiT29Fb BcnrOLW+4wjbnludojNgVYRXRZwm0IP9soImaf8zLIUQW2/QQatVq3gKZHQ0wXe2T47p wmL4DPbrVIzBR3XNPiiWblyibrdW8QuO0WLPobNbTsvD5/vPI8uFkGxyYBfKhUNGgpzO DvyQ== X-Gm-Message-State: APjAAAX3+tyt99oIYnU2dKYyHotSULApK6LQUnVr3reik3gwOF57HZmq foMlDM3sEN3Qqx6SW5kQcgrNHoEJGZc= X-Google-Smtp-Source: APXvYqze0cnWtx/Dl0fn5+ReKlBe4cBkVRbkGqgDamJGDmEjlxVr2vRxk4Mbfp9dph2H//7NoGzmzw== X-Received: by 2002:a37:f50a:: with SMTP id l10mr13774028qkk.196.1567867837735; Sat, 07 Sep 2019 07:50:37 -0700 (PDT) Received: from spy ([50.235.236.73]) by smtp.gmail.com with ESMTPSA id 44sm481397qtt.13.2019.09.07.07.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Sep 2019 07:50:36 -0700 (PDT) Sender: Mark Johnston Date: Sat, 7 Sep 2019 10:50:34 -0400 From: Mark Johnston To: Slawa Olhovchenkov Cc: Andriy Gapon , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351673 - in head: lib/libmemstat share/man/man9 sys/cddl/compat/opensolaris/kern sys/kern sys/vm Message-ID: <20190907145034.GB6523@spy> References: <201909012222.x81MMh0F022462@repo.freebsd.org> <79c74018-1329-ee69-3480-e2f99821fa93@FreeBSD.org> <20190903161427.GA38096@zxy.spb.ru> <20190903220106.GB26733@raichu> <20190904144524.GD3953@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904144524.GD3953@zxy.spb.ru> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 46Qcmb00Dvz4dct X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=VQmjzVSL; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::734 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-1.07 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-2.89)[ip: (-9.40), ipnet: 2607:f8b0::/32(-2.75), asn: 15169(-2.27), country: US(-0.05)]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; RECEIVED_SPAMHAUS_CSS(4.00)[73.236.235.50.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.3]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[4.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Sep 2019 14:50:40 -0000 On Wed, Sep 04, 2019 at 05:45:24PM +0300, Slawa Olhovchenkov wrote: > On Tue, Sep 03, 2019 at 06:01:06PM -0400, Mark Johnston wrote: > > > Mostly problem I am see at this > > > work -- very slowly vm_page_free(). May be currenly this is more > > > speedy... > > > > How did you determine this? > > This is you guess: So was the guess correct? If so, IMO the real solution is to avoid kmem_* for data buffers and use ABD instead. > ====== > > while ((slab = SLIST_FIRST(&freeslabs)) != NULL) { > > SLIST_REMOVE(&freeslabs, slab, uma_slab, us_hlink); > > keg_free_slab(keg, slab, keg->uk_ipers); > > } > > 2019 Feb 2 19:49:54.800524364 zio_data_buf_1048576 1032605 cache_reclaim limit 100 dom 0 nitems 1672 imin 298 > > 2019 Feb 2 19:49:54.800524364 zio_data_buf_1048576 1033736 cache_reclaim recla 149 dom 0 nitems 1672 imin 298 > > 2019 Feb 2 19:49:54.802524468 zio_data_buf_1048576 3119710 cache_reclaim limit 100 dom 1 nitems 1 imin 0 > > 2019 Feb 2 19:49:54.802524468 zio_data_buf_1048576 3127550 keg_drain2 > > 2019 Feb 2 19:49:54.803524487 zio_data_buf_1048576 4444219 keg_drain3 > > 2019 Feb 2 19:49:54.838524634 zio_data_buf_1048576 39553705 keg_drain4 > > 2019 Feb 2 19:49:54.838524634 zio_data_buf_1048576 39565323 zone_reclaim:return > > > > 35109.486 ms for last loop, 149 items to freed. > > 35ms to free 149MB (38144 4KB pages), so roughly 1us per page. That > does seem like a lot, but freeing a page (vm_page_free(m)) is much > more expensive than freeing an item to UMA (i.e., uma_zfree()). > Most of that time will be spent in _kmem_unback(). > ======