Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Jun 2025 23:31:26 GMT
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: f1f71cc717aa - main - fwget: pci_intel_video: do no log on no match
Message-ID:  <202506182331.55INVQH8026977@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=f1f71cc717aa672caf046ffe1f3dd77e622b8b35

commit f1f71cc717aa672caf046ffe1f3dd77e622b8b35
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2025-06-18 16:50:18 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2025-06-18 23:31:13 +0000

    fwget: pci_intel_video: do no log on no match
    
    We should never "log" a statement on no match for a given device we
    do not know about.  We do not control the PCI ID assignments and thus
    cannot predict if we would even support such a device.
    
    This also triggers an invalid output in the installer.
    
    Leave it as log_verbose for now.
    
    Sponsored by:   The FreeBSD Foundation
    MFC after:      3 days
    PR:             287639
    Reviewed by:    manu, emaste
    Differential Revision: https://reviews.freebsd.org/D50916
---
 usr.sbin/fwget/pci/pci_video_intel | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usr.sbin/fwget/pci/pci_video_intel b/usr.sbin/fwget/pci/pci_video_intel
index 3824c4a49ffb..2f9012ed1f52 100644
--- a/usr.sbin/fwget/pci/pci_video_intel
+++ b/usr.sbin/fwget/pci/pci_video_intel
@@ -72,7 +72,7 @@ pci_video_intel()
 			addpkg "gpu-firmware-intel-kmod-alderlake gpu-firmware-intel-kmod-tigerlake"
 			;;
 		*)
-			log "No package found for device $1"
+			log_verbose "No package found for device $1"
 			;;
 	esac
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506182331.55INVQH8026977>