From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 23:54:27 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A6C516A41C; Mon, 6 Jun 2005 23:54:27 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09F8343D53; Mon, 6 Jun 2005 23:54:26 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j56NsQar011157; Mon, 6 Jun 2005 16:54:26 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j56NsQWI011156; Mon, 6 Jun 2005 16:54:26 -0700 Date: Mon, 6 Jun 2005 16:54:26 -0700 From: Brooks Davis To: Doug Barton Message-ID: <20050606235426.GA10526@odin.ac.hmc.edu> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: <42A4CA37.1050201@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org, "J.R. Oldroyd" Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 23:54:27 -0000 --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 06, 2005 at 03:12:07PM -0700, Doug Barton wrote: > J.R. Oldroyd wrote: > >I posted this to -current yesterday; it was suggested I resend to > >this list. >=20 > Thanks for bringing this up, and yes, we prefer discussion here on rc.d= =20 > topics. >=20 > >----- Forwarded message from "J.R. Oldroyd" ----- > > > >From: "J.R. Oldroyd" > >Date: Thu, 2 Jun 2005 17:10:23 -0400 > >Subject: Use of rcorder for local rc.d/*.sh scripts > >To: freebsd-current@freebsd.org > > > >Is there a reason that rcorder is not used in /etc/rc.d/localpkg > >so that the scripts there can be ordered using their tags? > > > >If not, could we make the following change to /etc/rc.d/localpkg: > > > >--- localpkg.orig Fri Oct 8 13:52:43 2004 > >+++ localpkg Thu Jun 2 16:53:56 2005 > >@@ -36,7 +36,7 @@ > > done > > script_save_sep=3D"$IFS" > > IFS=3D"${script_name_sep}" > >- for script in ${slist}; do > >+ for script in `rcorder -s nostart ${slist} 2>/dev/null`; do >=20 > This is an interesting approach. I'm in favor of incorporating rcorder fo= r=20 > local scripts (whether ports, or homegrown stuff), but I think I prefer a= n=20 > approach that brings all the scripts into the fray, so that local scripts= =20 > that need to execute before parts of the base can do so. Have you put any= =20 > thought into such an approach? This isn't feasable in the general case with current infrastructure. The problem is that you need to make it up to mountcritremote before you have any assurance that /usr/local/etc exists. Ports contains a work around that allows port to install script in /etc/rc.d if they truly need to appear before localpkg. Such ports generally still need to have scripts that run after mountcritlocal and won't work on systems where /usr/local is remote unless it is on /. =46rom the perspective of someone who works on the diskless scripts, I think that sorting scripts in localpkg and using this hack is a decent comprimise. Another note, this decision will need to be discussed with ports@ since there are a lot of scripts in ${LOCALBASE}/rc.d. There's also at least one binary (postfix). I'd like to see this change happen, but there are a lot of issues to work out. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCpOIxXY6L6fI4GtQRAsnWAJ9oPMlKK7h4IDNTDWXiBflwAOv5rQCeKZ98 p7Cg4fyA5YGpbn3A5BGrDM0= =OIuY -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--