From owner-freebsd-current@FreeBSD.ORG  Tue Jul  2 20:30:53 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id C163DA62
 for <freebsd-current@freebsd.org>; Tue,  2 Jul 2013 20:30:53 +0000 (UTC)
 (envelope-from edschouten@gmail.com)
Received: from mail-vb0-x233.google.com (mail-vb0-x233.google.com
 [IPv6:2607:f8b0:400c:c02::233])
 by mx1.freebsd.org (Postfix) with ESMTP id 887F413BE
 for <freebsd-current@freebsd.org>; Tue,  2 Jul 2013 20:30:53 +0000 (UTC)
Received: by mail-vb0-f51.google.com with SMTP id x17so5016746vbf.38
 for <freebsd-current@freebsd.org>; Tue, 02 Jul 2013 13:30:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=n9etLcHHuf8LDeKC9JN0S08YKjuKlueRUe1ejEvMJZM=;
 b=Hkx2U8/oeHS/+SpJSq272fm3V5fAESBdPG3wbkrZJFG08TcMyw2kpYg/KaapmGdswA
 O6P+rtOOFIKXkTLHe+oqJ2lfN1Mg8aTebDf+n6wx2e+uuS45YpVfb3g4KYcR2USO+tu/
 pQUyPewkUhVbCmWzVyNkZhVxdmtzXuQXRKSVJ24BHoz191D/XbMXUfLJLO79XwkJmDa5
 gDGdYuK9GhV6isrbGnLvCU0JzLY/H1yT7TNCljAqewCgwxRKCZHkEoEGlFOAK2/K1fvg
 YDsNKdtqCDnpry0y0tAjs5UyWqSYCp0qyBLjZlIbAOIhRuG9eoHqQAzlL8+bZEkVIV6W
 UqAw==
MIME-Version: 1.0
X-Received: by 10.58.24.201 with SMTP id w9mr12077504vef.82.1372797053056;
 Tue, 02 Jul 2013 13:30:53 -0700 (PDT)
Sender: edschouten@gmail.com
Received: by 10.220.86.200 with HTTP; Tue, 2 Jul 2013 13:30:53 -0700 (PDT)
In-Reply-To: <20130702201728.GA68544@troutmask.apl.washington.edu>
References: <20130702201728.GA68544@troutmask.apl.washington.edu>
Date: Tue, 2 Jul 2013 22:30:53 +0200
X-Google-Sender-Auth: JJd3oknGrMymb0c0B4jBsv5srww
Message-ID: <CAJOYFBCWzzT7kSABROsyJsbt+N=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com>
Subject: Re: [PATCH] nvmecontrol breaks world
From: Ed Schouten <ed@80386.nl>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Content-Type: text/plain; charset=UTF-8
Cc: FreeBSD Current <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jul 2013 20:30:53 -0000

2013/7/2 Steve Kargl <sgk@troutmask.apl.washington.edu>:
> Could someone (this could even be me, but need approval) please
> fix nvmecontrol?

off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?
Also, the call of malloc(sb.st_size) is not really safe...


--
Ed Schouten <ed@80386.nl>