From owner-p4-projects@FreeBSD.ORG  Mon Jul 13 15:28:01 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id BEE871065673; Mon, 13 Jul 2009 15:28:00 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D0F7106564A
	for <perforce@FreeBSD.org>; Mon, 13 Jul 2009 15:28:00 +0000 (UTC)
	(envelope-from syl@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 61C238FC14
	for <perforce@FreeBSD.org>; Mon, 13 Jul 2009 15:28:00 +0000 (UTC)
	(envelope-from syl@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n6DFS0Xf009175
	for <perforce@FreeBSD.org>; Mon, 13 Jul 2009 15:28:00 GMT
	(envelope-from syl@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n6DFS0ur009173
	for perforce@freebsd.org; Mon, 13 Jul 2009 15:28:00 GMT
	(envelope-from syl@FreeBSD.org)
Date: Mon, 13 Jul 2009 15:28:00 GMT
Message-Id: <200907131528.n6DFS0ur009173@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	syl@FreeBSD.org using -f
From: Sylvestre Gallon <syl@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 166012 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2009 15:28:01 -0000

http://perforce.freebsd.org/chv.cgi?CH=166012

Change 166012 by syl@syl_pablo on 2009/07/13 15:27:42

	factorise ctrl/bulk/intr code.

Affected files ...

.. //depot/projects/soc2009/syl_usb/src/sys/dev/usb/controller/s3c24xxdci.c#8 edit

Differences ...

==== //depot/projects/soc2009/syl_usb/src/sys/dev/usb/controller/s3c24xxdci.c#8 (text+ko) ====

@@ -160,111 +160,49 @@
 }
 
 /*
- * s3c24xxdci ctrl support
+ * s3c24xxdci ctrl/bulk/intr support
  */
 
 static void
-s3c24dci_device_ctrl_open(struct usb_xfer *xfer)
+s3c24dci_device_dummy(struct usb_xfer *xfer)
 {
 	return ;
 }
 
 static void
-s3c24dci_device_ctrl_close(struct usb_xfer *xfer)
+s3c24dci_device_xxx_start(struct usb_xfer *xfer)
 {
-	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
+	s3c24dci_setup_standard_chain(xfer);
+	s3c24dci_start_standard_chain(xfer);
 	return ;
 }
 
 static void
-s3c24dci_device_ctrl_start(struct usb_xfer *xfer)
+s3c24dci_device_xxx_close(struct usb_xfer *xfer)
 {
+	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
 	return ;
 }
 
-static void
-s3c24dci_device_ctrl_enter(struct usb_xfer *xfer)
-{
-	return ;
-}
-
 struct usb_pipe_methods s3c24dci_device_ctrl_methods = {
-	.open = s3c24dci_device_ctrl_open,
-	.close = s3c24dci_device_ctrl_close,
-	.enter = s3c24dci_device_ctrl_enter,
-	.start = s3c24dci_device_ctrl_start,
+	.open = s3c24dci_device_dummy,
+	.enter = s3c24dci_device_dummy,
+	.close = s3c24dci_device_xxx_close,
+	.start = s3c24dci_device_xxx_start,
 };
 
-/*
- * s3c24xxdci bulk support
- */
-
-static void
-s3c24dci_device_bulk_open(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_bulk_close(struct usb_xfer *xfer)
-{
-	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
-	return ;
-}
-
-static void
-s3c24dci_device_bulk_start(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_bulk_enter(struct usb_xfer *xfer)
-{
-	return ;
-}
-
 struct usb_pipe_methods s3c24dci_device_bulk_methods = {
-	.open = s3c24dci_device_bulk_open,
-	.close = s3c24dci_device_bulk_close,
-	.enter = s3c24dci_device_bulk_enter,
-	.start = s3c24dci_device_bulk_start,
+	.open = s3c24dci_device_dummy,
+	.enter = s3c24dci_device_dummy,
+	.close = s3c24dci_device_xxx_close,
+	.start = s3c24dci_device_xxx_start,
 };
 
-/*
- * s3c24xxdci interrupt support
- */
-
-static void
-s3c24dci_device_intr_open(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_intr_close(struct usb_xfer *xfer)
-{
-	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
-	return ;
-}
-
-static void
-s3c24dci_device_intr_start(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_intr_enter(struct usb_xfer *xfer)
-{
-	return ;
-}
-
 struct usb_pipe_methods s3c24dci_device_bulk_methods = {
-	.open = s3c24dci_device_intr_open,
-	.close = s3c24dci_device_intr_close,
-	.enter = s3c24dci_device_intr_enter,
-	.start = s3c24dci_device_intr_start,
+	.open = s3c24dci_device_dummy,
+	.enter = s3c24dci_device_dummy,
+	.close = s3c24dci_device_xxx_close,
+	.start = s3c24dci_device_xxx_start,
 };
 
 /*