From owner-freebsd-ports Fri Jan 18 6:37:24 2002 Delivered-To: freebsd-ports@freebsd.org Received: from wwweasel.geeksrus.net (wwweasel.geeksrus.net [64.67.200.82]) by hub.freebsd.org (Postfix) with ESMTP id B5ECA37B405 for ; Fri, 18 Jan 2002 06:37:21 -0800 (PST) Received: (from alane@localhost) by wwweasel.geeksrus.net (8.11.6/8.11.6) id g0IEZw639710; Fri, 18 Jan 2002 09:35:58 -0500 (EST) (envelope-from alane) Date: Fri, 18 Jan 2002 09:35:58 -0500 From: Alan Eldridge To: Fernan Aguero Cc: "Simon 'corecode' Schubert" , ports@FreeBSD.ORG Subject: Re: submit an almost finished port for testing? Message-ID: <20020118143558.GA39626@wwweasel.geeksrus.net> References: <20020117120606.D78437@iib.unsam.edu.ar> <20020117233911.55042490.corecode@corecode.ath.cx> <20020118110520.A31480@iib.unsam.edu.ar> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020118110520.A31480@iib.unsam.edu.ar> User-Agent: Mutt/1.3.25i Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Fri, Jan 18, 2002 at 11:05:20AM -0300, Fernan Aguero wrote: >Default option will be no kde. If people want it they can say >'make WITH_KDE=YES'. Is that the idea? > >(Stupid question: i suppose that if i type WITH_KDE=NO then >.if defined(WITH_KDE) will still evaluate true, isn't it?) Yup. 1. The result when someone does make WITH_KDE=no is somewhat surprising. 2. Most knobs in Makefiles use lower-case values. 3. OpenBSD, as a policy, uses ${WITH_FOO:L} to test the lowercased text of the value. This way the user doesn't have to remember which way to spell: yes or YES or NO or no or YeS or nO. Taking all this together, I *would* suggest using: .if defined(WITH_KDE) && ${WITH_KDE:L} == "yes" except that make chokes on that if WITH_KDE is not defined. So, if you really want to be anal about it, and there's nothing *wrong* with that, you could say: .if !defined(WITH_KDE) WITH_KDE=no .endif .if ${WITH_KDE:L} = yes USE_KDE_VERSION=2 .else CONFIGURE_ARGS+=--disable-kde .endif -- Alan Eldridge Pmmfmffmmfmp mmmpppppffmpmfpmpppff PmpMpmMpp ppfppp MpfpffmppmppMmpFmmMpm mfpmmmmmfpmpmpppff. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message