From nobody Fri Feb 16 15:51:26 2024 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TbxHg49W0z51s4Y for ; Fri, 16 Feb 2024 15:51:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TbxHg35gVz4t0V for ; Fri, 16 Feb 2024 15:51:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708098687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mRVqMweIRvZhunvEqOtOWhkh36KZujDCeMIcxC8W6ow=; b=Rm34eh2xcs0xDbP8FZbhdHQn+of5Z0i5fDNzqyFLpFEGXNkJuxHq9TdGv9LosrpBBaBYjZ Mt7KvJnhf25uXtqPcREZi9rlbuU+6d/ie5UNTcCdChjvwL4OEbR1+CVcDDcZW74wyjm3fG SwivESry82gmoVzIfjcejUAhuZ9YkXDnv7KLElLnzN8nXWIr1BFcVtfEuL7hwG8X7HmvQB drKf+ITv0WpdPCLiuPPkvmdjYMfu/q1uAF6eXTQNnx84roi0Cjc89jt4qJELEbqoB6MRi4 QdJgqRv6TwEsmbw5RkdQ5hbFlwRMeiGdXVaHNGMbwBaeUA84GXACoSRgWMqCcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708098687; a=rsa-sha256; cv=none; b=s5xplMEV2u8Wri8XabnJkYC+4TRRfDMJP7bXnOqW2Ke+2RwMmsg4cMMWDBmJoomhUKjsLu rAPo3Bgk/VXt6SFdprfy/5xqJyDBGyu56KXJJfXFyJt538XttE9obe5Oe9UwS+cEJEmkNR IJk1KtZlIXKHiSVSnNsWcrNZszRvMefTQTxhqHVKnGWG5yLH0HD8xQgoU4u1lmGE8jV2Ug s0oXrWf/9GlDlmUzTFr+0vQPBPJ4/Wsm8WVsU0Z3ueHjf1e+N0jawMVEbCdDWXU0Gr3Nv2 2YdjLx3rMd52t85P1+KjguuoZg5CAYmpQoRd1dav2nkQ7u+1CFv527yb1ulzaw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TbxHg2CtbzWwf for ; Fri, 16 Feb 2024 15:51:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41GFpRPp004583 for ; Fri, 16 Feb 2024 15:51:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41GFpRLW004581 for wireless@FreeBSD.org; Fri, 16 Feb 2024 15:51:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 274382] iwlwifi Invalid TXQ id Date: Fri, 16 Feb 2024 15:51:26 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: tracking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274382 --- Comment #42 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dfa4e4257943650c0b5f58c01bb0bdfade= a61dfb2 commit fa4e4257943650c0b5f58c01bb0bdfadea61dfb2 Author: Bjoern A. Zeeb AuthorDate: 2024-02-14 21:56:48 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-02-16 15:50:11 +0000 LinuxKPI: 802.11: lsta txq locking cleanup Rename the LSTA lock to LSTA_TXQ lock as that is really what it is and put down the full set of macros. Replace the init and destroy with the macro invocation rather than direct code. Put locking around the txq_ready unset and check. Move the taskq_enqueue call under lock to be sure we do not call it anymore after txq_ready got unset. Leave a comment related to the node reference which is passed into the TX path on the recvif mbuf pointer. Fixes: 0936c648ad0ee PR: 274382 (possibly) MFC after: 1 day Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D43909 sys/compat/linuxkpi/common/src/linux_80211.c | 31 ++++++++++++++++++------= ---- sys/compat/linuxkpi/common/src/linux_80211.h | 14 +++++++++++-- 2 files changed, 32 insertions(+), 13 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=