From owner-svn-ports-all@freebsd.org Thu May 18 02:27:21 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EFE61D72ED2; Thu, 18 May 2017 02:27:21 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "apnoea.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 364DC17D4; Thu, 18 May 2017 02:27:20 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id a7cbd25f TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 17 May 2017 20:27:13 -0600 (MDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r440978 - in head: devel devel/npm-amdefine devel/npm-clean-css devel/npm-clean-css/files devel/npm-commander devel/npm-commander/files devel/npm-graceful-readlink devel/npm-source-map ... From: Adam Weinberger In-Reply-To: Date: Wed, 17 May 2017 20:27:12 -0600 Cc: Rodrigo Osorio , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201705152205.v4FM5kIw055373@repo.freebsd.org> <6F0B8538-C30A-42A4-A3C3-D0BA1FA8F6F4@adamw.org> To: Rodrigo Osorio X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 02:27:22 -0000 > On 16 May, 2017, at 2:57, Rodrigo Osorio wrote: >=20 > On 05/16/17 00:27, Adam Weinberger wrote: >>> On 15 May, 2017, at 16:05, Rodrigo Osorio = wrote: >>>=20 >>> Author: rodrigo >>> Date: Mon May 15 22:05:46 2017 >>> New Revision: 440978 >>> URL: https://svnweb.freebsd.org/changeset/ports/440978 >>>=20 >>> Log: >>> Add npm-less-plugin-clean-css a www/lesc tool pluggin and its = dependencies >>>=20 >>> www/npm-less-plugin-clean-css: Compresses the css output from less = using clean-css >>> ` devel/npm-clean-css: Fast and efficient CSS optimizer for node.js = and the Web >>> ` devel/npm-source-map: Parse and consume source maps >>> | ` devel/npm-amdefine: Implementation of AMD's define() in Node >>> ` devel/npm-commander: node.js command-line interfaces made easy >>> ` devel/npm-graceful-readlink: Graceful fs.readlink >> What do all these ports do that npm doesn't already do, especially = given that this will cause breakage for everybody with any of these = modules installed globally? >>=20 >> # Adam >>=20 >>=20 > Hi Adam, >=20 > That's npm dependencies that need to be packages properly, I'll feel = unsafe if the port > relies on npm to download external sources from github during the = packaging, without > checking the integrity. >=20 > Of course, this could be an issue for peoples who deploys npm packages = on their own, > but how can we handle this ? Maybe dep search path should be set = manually if you > install unpackaged npm tools ? >=20 > I run a quick test, but apparently node uses in tree dependencies = before global. The summary here is that having node packages in the ports tree causes = more problems than it solves. A clarification of packaging policy is = forthcoming, but the gist of it is that node packages aren't candidates = for ports unless they're dependencies of other ports. Plus, = npm-clean-css is causing build failures on at least one builder = (http://package19.nyi.freebsd.org/data/103i386-default-build-as-user/44106= 2/logs/npm-clean-css-4.1.1.log). These ports should be backed out please, Rodrigo. I'll explain more = shortly in response to David Naylor's email in this thread. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org