From owner-svn-src-all@FreeBSD.ORG Wed Dec 30 22:34:27 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 351EA106566B; Wed, 30 Dec 2009 22:34:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 235F48FC15; Wed, 30 Dec 2009 22:34:27 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id nBUMYRoR074454; Wed, 30 Dec 2009 22:34:27 GMT (envelope-from jhb@svn.freebsd.org) Received: (from jhb@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id nBUMYRHf074452; Wed, 30 Dec 2009 22:34:27 GMT (envelope-from jhb@svn.freebsd.org) Message-Id: <200912302234.nBUMYRHf074452@svn.freebsd.org> From: John Baldwin Date: Wed, 30 Dec 2009 22:34:27 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r201286 - head/sys/dev/cardbus X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2009 22:34:27 -0000 Author: jhb Date: Wed Dec 30 22:34:26 2009 New Revision: 201286 URL: http://svn.freebsd.org/changeset/base/201286 Log: Fix an error case I missed in the previous change so that the CIS resource is fully cleaned up if we fail to find the CIS in the devices ROM. Modified: head/sys/dev/cardbus/cardbus_cis.c Modified: head/sys/dev/cardbus/cardbus_cis.c ============================================================================== --- head/sys/dev/cardbus/cardbus_cis.c Wed Dec 30 22:13:01 2009 (r201285) +++ head/sys/dev/cardbus/cardbus_cis.c Wed Dec 30 22:34:26 2009 (r201286) @@ -530,8 +530,8 @@ cardbus_read_tuple_init(device_t cbdev, CARDBUS_EXROM_DATA_INDICATOR) & 0x80) != 0) { device_printf(cbdev, "Cannot find CIS in " "Option ROM\n"); - bus_release_resource(child, SYS_RES_MEMORY, - *rid, res); + cardbus_read_tuple_finish(cbdev, child, *rid, + res); *rid = 0; return (NULL); }