From owner-cvs-all@FreeBSD.ORG  Fri Apr 29 21:24:25 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B61C616A4CE; Fri, 29 Apr 2005 21:24:25 +0000 (GMT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9B50843D41; Fri, 29 Apr 2005 21:24:20 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j3TLSI7H033034;
	Fri, 29 Apr 2005 15:28:18 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <4272A5F6.4000902@samsco.org>
Date: Fri, 29 Apr 2005 15:24:06 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050218
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Vinod Kashyap <vkashyap@amcc.com>
References: <IFQ8CY02.172@hadar.amcc.com>
In-Reply-To: <IFQ8CY02.172@hadar.amcc.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.2
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org
cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/twa tw_osl_cam.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Apr 2005 21:24:25 -0000

Vinod Kashyap wrote:
> 
>>-----Original Message-----
>>From: owner-src-committers@FreeBSD.org
>>[mailto:owner-src-committers@FreeBSD.org]On Behalf Of Bjoern A. Zeeb
>>Sent: Friday, April 29, 2005 1:29 PM
>>To: Vinod Kashyap
>>Cc: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; 
>>cvs-all@FreeBSD.org
>>Subject: Re: cvs commit: src/sys/dev/twa tw_osl_cam.c
>>
>>
>>On Fri, 29 Apr 2005, Vinod Kashyap wrote:
>>
>>
>>>vkashyap    2005-04-29 20:03:20 UTC
>>>
>>>  FreeBSD src repository
>>>
>>>  Modified files:
>>>    sys/dev/twa          tw_osl_cam.c
>>>  Log:
>>>  Make call to tw_cl_deferred_interrupt in twa_poll, not 
>>
>>dependent on the
>>
>>>  return value from tw_cl_interrupt.
>>>
>>>  Revision  Changes    Path
>>>  1.2       +12 -2     src/sys/dev/twa/tw_osl_cam.c
>>
>>With this I can reboot the machine again. Thanks.
>>
> 
> 
> I still believe that CAM should not be calling the polling function
> when interrupts are active, but in the absence of an answer to why
> that is so, this can be a work-around.
> 
> 

CAM calls the poll routine when it's not sure if interrupts are
enabled and it wants to make sure that SIM will complete all
outstanding commands.  It's the same way that every other CAM
driver in the tree is written.

Scott