From owner-freebsd-ports Tue Jun 16 21:29:14 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA04338 for freebsd-ports-outgoing; Tue, 16 Jun 1998 21:29:14 -0700 (PDT) (envelope-from owner-freebsd-ports@FreeBSD.ORG) Received: from flarn.dyn.ml.org (mph@usr125.third-wave.com [147.72.122.40]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA04324 for ; Tue, 16 Jun 1998 21:28:43 -0700 (PDT) (envelope-from mph@flarn.dyn.ml.org) Received: (from mph@localhost) by flarn.dyn.ml.org (8.8.8/8.8.8) id AAA00415; Wed, 17 Jun 1998 00:25:04 -0400 (EDT) (envelope-from mph) Message-ID: <19980617002503.A348@flarn.dyn.ml.org> Date: Wed, 17 Jun 1998 00:25:03 -0400 From: Matthew Hunt To: ac199@hwcn.org, daetalus@his.com Cc: freebsd-ports@FreeBSD.ORG Subject: Re: Do Committers like ftp or diff Mail-Followup-To: ac199@hwcn.org, daetalus@his.com, freebsd-ports@FreeBSD.ORG References: <199806162354.TAA00718@daetalus.his.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.91.1i In-Reply-To: ; from Tim Vanderhoek on Tue, Jun 16, 1998 at 11:32:56PM -0400 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Tue, Jun 16, 1998 at 11:32:56PM -0400, Tim Vanderhoek wrote: > !!diff -ur e93 e93_orig [ shouldn't that be -urN ? And the other way around? ] > From vi, of course. If you're using something else, I can't say > I have too much pity. ;-) Since I'm less vi-literate, I just make a patchfile: diff -urN myport.orig myport > ~/myport.diff I review it, for obvious stupidity (forgot "make clean", etc.): less ~/myport.diff And then, when editing my PR, I just insert the file. In vi, that would be ":r ~/myport.diff"; in Emacs, it would be "C-x C-i ~/myport.diff RET". > And the committers prefer diff. Except for the exceptions > documented in the handbook. Absolutely. Either you make the diff, or we have to. Strangely enough, we prefer that you do it. :-) Besides, you should run "diff" anyhow, to easily review the changes you're submitting. -- Matthew Hunt * Stay close to the Vorlon. http://www.pobox.com/~mph/pgp.key for PGP public key 0x67203349. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message