Date: Tue, 24 Mar 2015 19:27:56 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: Thierry Thomas <thierry@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, marino@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381955 - head/graphics/gdal Message-ID: <20150324192756.06aea6da@kalimero.tijl.coosemans.org> In-Reply-To: <20150323210505.GN7893@graf.pompo.net> References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323135711.GB27378@ivaldir.etoilebsd.net> <5510220D.3030505@FreeBSD.org> <20150323143311.GC27378@ivaldir.etoilebsd.net> <20150323182248.GG7893@graf.pompo.net> <55105B9C.6030404@marino.st> <20150323210505.GN7893@graf.pompo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Mar 2015 22:05:05 +0100 Thierry Thomas <thierry@FreeBSD.org> wro=
te:
> Le lun 23 mar 15 =C3=A0 19:29:48 +0100, John Marino <freebsd.contact@mari=
no.st>
> =C3=A9crivait=C2=A0:
>>> Something like:
>>> LDFLAGS+=3D ${PTHREAD_LIBS}
>>>=20
>>> In these cases, it seems better to keep PTHREAD_LIBS than to hardcode
>>> some variant of -lpthread.
>>>=20
>>> Regards,
>>>=20
>>=20
>> see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198794
>>=20
>> 1) it's set to -pthread right now
>> 2) PTHREAD_LIBS is supposed to disappear from ports.
>=20
> I know, but I'm just suggesting to keep it for these cases.
It used to be the case on FreeBSD that when you linked an executable to
a library that used threading API you also had to link the executable
with a threading library. So LDFLAGS+=3D${PTHREAD_LIBS} had to be added
to ports sometimes if one of their dependencies used threading. It
should be safe to remove these uses of ${PTHREAD_LIBS} now and then
there won't be that many left. I think it's ok to replace them with
-lpthread. There are other libraries missing sometimes and they don't
have a special variable either.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150324192756.06aea6da>