From owner-cvs-all Wed Sep 18 9:16:56 2002 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 708BA37B401; Wed, 18 Sep 2002 09:16:55 -0700 (PDT) Date: Wed, 18 Sep 2002 09:16:55 -0700 From: Juli Mallett To: Matthew Dillon Cc: Bruce Evans , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/make Makefile arch.c compat.c cond.c dir.c for.c job.c make.c make.h parse.c suff.c targ.c var.c Message-ID: <20020918091655.A89057@FreeBSD.org> References: <20020918221316.I15381-100000@gamplex.bde.org> <200209181534.g8IFYhFP085923@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200209181534.g8IFYhFP085923@apollo.backplane.com>; from dillon@apollo.backplane.com on Wed, Sep 18, 2002 at 08:34:43AM -0700 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: Matthew Dillon [ Data: 2002-09-18 ] [ Subjecte: Re: cvs commit: src/usr.bin/make Makefile arch.c compat.c cond.c dir.c for.c job.c make.c make.h parse.c suff.c targ.c var.c ] > As much as I usually disagree with BDE when it comes to > maintaining portability (aka on prototypes), I consider the > var-args MACRO(...) feature a travesty that should be avoided > at least for another few years. IMHO. > > I recommend using the trick KASSERT uses instead of using > a var-args macro. It isn't as pretty but you get the > same result. I was going to such, but had to deal with the fact that I didn't want people to have to use 'stderr' manually, so I could pass it to fprintf(3), and printf(3) of course goes to stdout. Error() [like panic(9)] adds a newline, thus making it unsuitable. I broke down and added Debug(), even though yesterday I swore I wouldn't. I gave up hope of finding any other method - maybe there isn't one. Any, it's done now. juli. -- Juli Mallett | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message