Date: Fri, 11 Aug 2017 12:58:25 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: raichoo <raichoo@googlemail.com> Cc: freebsd-hackers@freebsd.org Subject: Re: `ifconfig` patch to resolve IPv6 scope names Message-ID: <92290fd6-fa7f-5d62-732a-1353af612297@yandex.ru> In-Reply-To: <CAJaUxexd2ez=DezquYCcFiUG81K4tDEVTNNFnfe6u2-MZjiYZg@mail.gmail.com> References: <CAJaUxeyRQoQkVdb3jNim_BVbdtBp0hM1pn3AiaR_DPJZAyQapg@mail.gmail.com> <8ebce8ed-5b3f-2b59-5b37-f6af7f3d4c2b@yandex.ru> <CAJaUxexd2ez=DezquYCcFiUG81K4tDEVTNNFnfe6u2-MZjiYZg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--6MqdLMl0xTfo6GaFUBr5lvRV2cGiHfxLq
Content-Type: multipart/mixed; boundary="UQbhUc9cppqNQJ8sRWmfUlEqK9hhbAJ51";
protected-headers="v1"
From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
To: raichoo <raichoo@googlemail.com>
Cc: freebsd-hackers@freebsd.org
Message-ID: <92290fd6-fa7f-5d62-732a-1353af612297@yandex.ru>
Subject: Re: `ifconfig` patch to resolve IPv6 scope names
References: <CAJaUxeyRQoQkVdb3jNim_BVbdtBp0hM1pn3AiaR_DPJZAyQapg@mail.gmail.com>
<8ebce8ed-5b3f-2b59-5b37-f6af7f3d4c2b@yandex.ru>
<CAJaUxexd2ez=DezquYCcFiUG81K4tDEVTNNFnfe6u2-MZjiYZg@mail.gmail.com>
In-Reply-To: <CAJaUxexd2ez=DezquYCcFiUG81K4tDEVTNNFnfe6u2-MZjiYZg@mail.gmail.com>
--UQbhUc9cppqNQJ8sRWmfUlEqK9hhbAJ51
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 10.08.2017 23:02, raichoo via freebsd-hackers wrote:
> Oh boy, should have read more code before posting that ^^.
>=20
> Thanks a lot for your feedback :)
>=20
> I've modified that patch to make it use the macros defined in in6.h. I'=
m
> also quite
> aware that this patch might be rejected since it might break script
> depending on `ifconfig`
> output. But it's a useful little learning experience anyway :)
>=20
> Kind regards,
> raichoo
>=20
> Here's the new iteration:
>=20
> diff --git a/sbin/ifconfig/af_inet6.c b/sbin/ifconfig/af_inet6.c
> index e93d94355e..e1d44395c9 100644
> --- a/sbin/ifconfig/af_inet6.c
> +++ b/sbin/ifconfig/af_inet6.c
> @@ -167,6 +167,35 @@ setip6eui64(const char *cmd, int dummy __unused, i=
nt s,
> }
>=20
> static void
> +in6_addr_scope(const struct in6_addr *addr)
> +{
> + if (IN6_IS_ADDR_LINKLOCAL(addr))
> + printf("link-local ");
> + else if (IN6_IS_ADDR_SITELOCAL(addr))
> + printf("site-local ");
> + else if (IN6_IS_ADDR_MULTICAST(addr)) {
> + printf("multicast ");
> + switch (__IPV6_ADDR_MC_SCOPE(addr)) {
> + case __IPV6_ADDR_SCOPE_NODELOCAL:
> + printf("node-local ");
> + break;
> + case __IPV6_ADDR_SCOPE_LINKLOCAL:
> + printf("link-local ");
> + break;
> + case __IPV6_ADDR_SCOPE_SITELOCAL:
> + printf("site-local ");
> + break;
> + case __IPV6_ADDR_SCOPE_ORGLOCAL:
> + printf("organization-local ");
> + break;
> + case __IPV6_ADDR_SCOPE_GLOBAL:
> + printf("global ");
> + break;
> + }
> + }
> +}
Hi,
I'm not sure how it is useful configuring multicast addresses on the
interface. I think there are only four possible useful cases:
1. loopback address should be marked as link-local
2. link-local addresses should be marked as link-local
3. site-local addresses should be marked as site-local
4. all other non multicast addresses should be marked as global
Also, AFAIR, the site-local scope was deprecated a long time ago.
--=20
WBR, Andrey V. Elsukov
--UQbhUc9cppqNQJ8sRWmfUlEqK9hhbAJ51--
--6MqdLMl0xTfo6GaFUBr5lvRV2cGiHfxLq
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlmNf8EACgkQAcXqBBDI
oXp6MAf+P3hJviN6fDQ9okEFyyqkgEBU7N4q8zCSUlXxpWXUyFIW7iXZAlv9Kjrd
WRAsCiPZ0nlotQaE29JuFcBgzmfsilfXQnQLg1nfpkyO4OEWERANaS6zeEGhgLfP
Hf4EQ2w0bPfU4prrjTc5mvnDl/tGIEpn0wUUzVl4GV1+yFO0EiiWYOPOCEA3uG1p
RE8dADqwwn5+5wM/MEzs+cZBXCegXfjEdPh5tz5rs5fuiuJ2oCXBgPGdYk5yRhJz
x2//5qZ75uMl2BjBwnhz9z6TKOFoWD8RoJR+8r0VCxaBaw/mIO47Abm1DGhuqf1x
tUM/HPE12RtZ0Ebqwzk9GwPNF4VXsQ==
=2xwf
-----END PGP SIGNATURE-----
--6MqdLMl0xTfo6GaFUBr5lvRV2cGiHfxLq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?92290fd6-fa7f-5d62-732a-1353af612297>