From owner-dev-commits-src-main@freebsd.org Sat Jan 23 20:21:09 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D4C9B4DCE28; Sat, 23 Jan 2021 20:21:09 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DNSFK5Thrz4tYl; Sat, 23 Jan 2021 20:21:09 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: by mail-ot1-x32f.google.com with SMTP id d1so8740574otl.13; Sat, 23 Jan 2021 12:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+GrODjKlfi+Rm3eh4gFBvmNljNwRtTVrCd0WR6o8nME=; b=PK5fePdXOmfGVFvnkMboOQQfNg+r9KYFqAj93O/OTA2Sx7urlWQJUqNYr1zigkGePN DFmIIa9fQROkGr3gKrlu4Gn6emxMTAK+IzAhnuU4xoK6pn0XEQHdBLUp87Mf6RjNWXn+ 0XJALTXX23wabON6tfTwRPCfGB7zBudEqjfsTMIWBvgRrvKp/ZpbcBWglRi5siSp2W5/ WuewJMyWU8PIa+mRNtKaFteo7T+4xpCSV2NM7i/6E1wG4mZO7h8u1AHlApVGT3D9Quul So7Z5t8jlIzW9dkXspvOihCNIFvsQs08h3d8dCmXZphel6k2hWPUrA45YsqqgxuQg2CB 6C0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+GrODjKlfi+Rm3eh4gFBvmNljNwRtTVrCd0WR6o8nME=; b=Mi5zUWjNnV6KNW3OhMQsM15MUoL9Wypksxn7KC/eVJ/95zQb1eOKt+WJP0zLVFRNJ8 0jNxKOWZ83BbFchC9xG/0qPUlqsNiKZ5TLoF/haeGgtolnbndYZsESeL7guIoLJ/yS6i l5wfVvbPoeFhLTh/e2oCR0fHLFVHSFAJ8t2CL10OF5rtxdljC4c1B9mOROFQFW50euEC qZGgSrBjjGJHXUECIxeoXWRycrYqUpZg/abZU8/dCDaOi+oWy7F7yHzVfxQstdVXByxG yQCuzifdOr4lyCE8uN/JyI8zD9Zqc2C2WNZnlxsJJ54Z8xOgw9W5fL4vgmH8+FlWUnvr ue+Q== X-Gm-Message-State: AOAM533Y1Ei7tprbSf0e4zuSaCTGB0/M6TLVNE4trSj/G3p+tWc8z+fe kkoPJYleeWTFTdp1vyXTJX5gAt04BDGN1SN6fKplQ19e X-Google-Smtp-Source: ABdhPJyIiFOQX9pVwID09Cp/NaNlBl0udzVBvcx6GHLqoxs5kf3T1+EiPSj4zABq8ykDTPwnWaDoghZvzRm9irHa1vU= X-Received: by 2002:a9d:3985:: with SMTP id y5mr7506955otb.202.1611433268293; Sat, 23 Jan 2021 12:21:08 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a4a:a187:0:0:0:0:0 with HTTP; Sat, 23 Jan 2021 12:21:07 -0800 (PST) In-Reply-To: <202101231810.10NIAKXd018767@gitrepo.freebsd.org> References: <202101231810.10NIAKXd018767@gitrepo.freebsd.org> From: Oliver Pinter Date: Sat, 23 Jan 2021 21:21:07 +0100 Message-ID: Subject: Re: git: 02ec31bdf60f - main - cache: add back target entry on rename To: Mateusz Guzik Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" X-Rspamd-Queue-Id: 4DNSFK5Thrz4tYl X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2021 20:21:09 -0000 On Saturday, January 23, 2021, Mateusz Guzik wrote: > The branch main has been updated by mjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id= > 02ec31bdf60fa3a8530544cb3c8c4ec1df6cde0d > > commit 02ec31bdf60fa3a8530544cb3c8c4ec1df6cde0d > Author: Mateusz Guzik > AuthorDate: 2021-01-23 17:21:42 +0000 > Commit: Mateusz Guzik > CommitDate: 2021-01-23 18:10:16 +0000 > > cache: add back target entry on rename > --- > sys/kern/vfs_cache.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c > index 770c8ebf061b..03bafc75acaa 100644 > --- a/sys/kern/vfs_cache.c > +++ b/sys/kern/vfs_cache.c > @@ -367,6 +367,10 @@ static bool __read_frequently cache_fast_revlookup = > true; > SYSCTL_BOOL(_vfs, OID_AUTO, cache_fast_revlookup, CTLFLAG_RW, > &cache_fast_revlookup, 0, ""); > > +static bool __read_mostly cache_rename_add = true; > +SYSCTL_BOOL(_vfs, OID_AUTO, cache_rename_add, CTLFLAG_RW, > + &cache_rename_add, 0, ""); It would be really if the description were filled with proper info. + > static u_int __exclusive_cache_line neg_cycle; > > #define ncneghash 3 > @@ -2731,6 +2735,21 @@ cache_vop_rename(struct vnode *fdvp, struct vnode > *fvp, struct vnode *tdvp, > } else { > cache_remove_cnp(tdvp, tcnp); > } > + > + /* > + * TODO > + * > + * Historically renaming was always purging all revelang entries, > + * but that's quite wasteful. In particular turns out that in many > cases > + * the target file is immediately accessed after rename, inducing > a cache > + * miss. > + * > + * Recode this to reduce relocking and reuse the existing entry > (if any) > + * instead of just removing it above and allocating a new one here. > + */ > + if (cache_rename_add) { > + cache_enter(tdvp, fvp, tcnp); > + } > } > > void > _______________________________________________ > dev-commits-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to "dev-commits-src-all- > unsubscribe@freebsd.org" >