From nobody Thu Jul 31 04:41:11 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bsxHC6SMtz63RSh; Thu, 31 Jul 2025 04:41:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bsxHC5d8Zz3LZw; Thu, 31 Jul 2025 04:41:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753936871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RUFggHysBZF0HFRSjrrLEx+xwqgZmddTSgnbsjuEUsI=; b=uBofPg/+icNUzwDC2E+VT3fAmWFwZPWeArN7r45HDRjxoK+9p8fbBHuanyH8TBHFqPes/U CoC4dFguic5E2pYwjMtipUC3wEqXm2geMSW7nSOwnsoQb4+UonmWRvBMNbbi7BlHkePdVi 2CUT8u7FYW7KH4NVBgr/uEZ+jGnXb9KZspOuzHzYWxoS2RfiZNiEfsZB2y8d4X959thr+k ddDU+EPw2lsY6u9TlevWxztg/mR21sQTwzA7Eq3u/1edLIjpLGxLATu53WmzYVAdFxTZQO rC9pvlIbUQyHuAYbPxxYKuv0kh5enV8A0fsHla4t9wnlJjMIj1Glsu8XDorweA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753936871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RUFggHysBZF0HFRSjrrLEx+xwqgZmddTSgnbsjuEUsI=; b=Olofy6JPuQvkD6fMUMbNPB5TFYueNlrYFIHgy290X5xUnryyNagcBl3POqoVYHYfu1Vnu+ BCYbR7TPF8kf2vwbTAcIjvOi8ufHAI2HlDIbRUAIkZFLucdUIPtwZK+BPto+Ef9oMMN88A MArkjLo24/jwu+ckciPRC1LLLVnSUnfB85tRxP0GIewtfkqo6i0lPWQUQSUI5maUiLC4we 2oFg3WxkneYFUHjYj3seFOVSeCO4RXdFLCCLggAHFdZnkficCadSedfdNJQ8Axfko3LBC9 JB0x0Zte4HGXx2W96RLBo2Jmyo1wqpwImEMtWIWKFGwNd4gzmP+8YkTLyZvzMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753936871; a=rsa-sha256; cv=none; b=tx0bKwzf3JnVqeQDoS8IwWCjdJBpiDqwcvqMU8eDVJqnnt9SjChFUoHpssFW1DDwHa5Nu1 TGCPltI9/3Vp4j7KmIdoEMLqVpQDopGInLHOnA8k7nUbXSduLRcp8eiHsUj2p+I5z/JRg4 pPc/0exHmO2inWpW95zQkia7vhTsYa7nmwSf7QX4IiyewnYcKbSp7mqh8Lv1Wm35/+VChB O1RCQV7bOCvDuSoWy9n7FaEe9nl9VHxcHpphkeGNzLOoFSCa9NPi9zLhyjb3uyhSYJTNwb s4F3nBLbSLNtYWLyHpISv3uK4l8nh8ABMYEfnJPKqJoITTh1r+BH6EL1+CpnJw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bsxHC4yntzmv8; Thu, 31 Jul 2025 04:41:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56V4fB7Z047321; Thu, 31 Jul 2025 04:41:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56V4fBAr047318; Thu, 31 Jul 2025 04:41:11 GMT (envelope-from git) Date: Thu, 31 Jul 2025 04:41:11 GMT Message-Id: <202507310441.56V4fBAr047318@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: cdd97f3aacf1 - stable/14 - qlnxe: Fix advertising the IFCAP_LINKSTATE capability List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: cdd97f3aacf1e509858207a0caa085b9c47e5e9e Auto-Submitted: auto-generated The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=cdd97f3aacf1e509858207a0caa085b9c47e5e9e commit cdd97f3aacf1e509858207a0caa085b9c47e5e9e Author: Zhenlei Huang AuthorDate: 2025-07-22 04:11:02 +0000 Commit: Zhenlei Huang CommitDate: 2025-07-31 04:40:23 +0000 qlnxe: Fix advertising the IFCAP_LINKSTATE capability The following up advertising of IFCAP_HWCSUM capability unconditionally overwrite IFCAP_LINKSTATE. Reviewed by: kbowling MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D51450 (cherry picked from commit c18860339d5051dea99cb5cee7e322ffa5dd2a81) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 39ecad8ef1e1..6519c216ebf5 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2308,8 +2308,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) else if (device_id == QLOGIC_PCI_DEVICE_ID_1644) if_setbaudrate(ifp, IF_Gbps(100)); - if_setcapabilities(ifp, IFCAP_LINKSTATE); - if_setinitfn(ifp, qlnx_init); if_setsoftc(ifp, ha); if_setflags(ifp, IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST); @@ -2343,7 +2341,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) if_setcapabilities(ifp, IFCAP_HWCSUM); if_setcapabilitiesbit(ifp, IFCAP_JUMBO_MTU, 0); - if_setcapabilitiesbit(ifp, IFCAP_VLAN_MTU, 0); if_setcapabilitiesbit(ifp, IFCAP_VLAN_HWTAGGING, 0); if_setcapabilitiesbit(ifp, IFCAP_VLAN_HWFILTER, 0); @@ -2352,6 +2349,7 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) if_setcapabilitiesbit(ifp, IFCAP_TSO4, 0); if_setcapabilitiesbit(ifp, IFCAP_TSO6, 0); if_setcapabilitiesbit(ifp, IFCAP_LRO, 0); + if_setcapabilitiesbit(ifp, IFCAP_LINKSTATE, 0); if_sethwtsomax(ifp, QLNX_MAX_TSO_FRAME_SIZE - (ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN));