From owner-svn-src-all@FreeBSD.ORG Thu Nov 25 08:31:24 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0BFC21065672; Thu, 25 Nov 2010 08:31:24 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe02.c2i.net [212.247.154.34]) by mx1.freebsd.org (Postfix) with ESMTP id 61C238FC08; Thu, 25 Nov 2010 08:31:22 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=yevn+QCjI6xy199BDvBOOiO14qYvyLq62he9tTtU3M8= c=1 sm=1 a=TEzOOrCWXzgA:10 a=N659UExz7-8A:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=6I5d2MoRAAAA:8 a=8TywCXDdWmK-7wZfpzUA:9 a=dUY03yq56rRi4QQVbaQA:7 a=DT8SCCgO5Jxfp-osezyYPwXGZxYA:4 a=pILNOxqGKmIA:10 a=wAwLPL-YCJS2XH5U:21 a=0iSz37en5HAzGZg8:21 a=i9M/sDlu2rpZ9XS819oYzg==:117 Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe02.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 53538773; Thu, 25 Nov 2010 09:31:20 +0100 From: Hans Petter Selasky To: Weongyo Jeong Date: Thu, 25 Nov 2010 09:32:04 +0100 User-Agent: KMail/1.13.5 (FreeBSD/8.1-STABLE; KDE/4.4.5; amd64; ; ) References: <201011250302.oAP32r6R091758@svn.freebsd.org> In-Reply-To: <201011250302.oAP32r6R091758@svn.freebsd.org> X-Face: +~\`s("[*|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(; _IjlA: hGE..Ew, XAQ*o#\/M~SC=S1-f9{EzRfT'|Hhll5Q]ha5Bt-s|oTlKMusi:1e[wJl}kd}GR Z0adGx-x_0zGbZj'e(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L' MIME-Version: 1.0 Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Message-Id: <201011250932.04579.hselasky@c2i.net> Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r215810 - head/sys/dev/usb X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2010 08:31:24 -0000 On Thursday 25 November 2010 04:02:53 Weongyo Jeong wrote: > Author: weongyo > Date: Thu Nov 25 03:02:53 2010 > New Revision: 215810 > URL: http://svn.freebsd.org/changeset/base/215810 > > Log: > Assigning the unit number for each interfaces could not use ubus->parent > because it could differ depending on the host controller type. It could > lead the duplicate unit number assignment. > > Modified: > head/sys/dev/usb/usb_pf.c > > Modified: head/sys/dev/usb/usb_pf.c > =========================================================================== > === --- head/sys/dev/usb/usb_pf.c Wed Nov 24 22:44:10 2010 (r215809) > +++ head/sys/dev/usb/usb_pf.c Thu Nov 25 03:02:53 2010 (r215810) > @@ -61,9 +61,10 @@ void > usbpf_attach(struct usb_bus *ubus) > { > struct ifnet *ifp; > + devclass_t dc = devclass_find("usbus"); > > ifp = ubus->ifp = if_alloc(IFT_USB); > - if_initname(ifp, "usbus", device_get_unit(ubus->parent)); > + if_initname(ifp, "usbus", devclass_get_count(dc)); > if_attach(ifp); > > KASSERT(sizeof(struct usbpf_pkthdr) == USBPF_HDR_LEN, I think you will get a multiple unit number if you unload+load a driver like EHCI/OHCI/UHCI. I suggest that you only make one ifp instance and route all traffic through that one. --HPS