From owner-cvs-all@FreeBSD.ORG Wed Mar 16 20:55:02 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E8B416A4FB for ; Wed, 16 Mar 2005 20:55:02 +0000 (GMT) Received: from mail23.sea5.speakeasy.net (mail23.sea5.speakeasy.net [69.17.117.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4706C43D54 for ; Wed, 16 Mar 2005 20:55:01 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 8998 invoked from network); 16 Mar 2005 20:55:01 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender )AES256-SHA encrypted SMTP for ; 16 Mar 2005 20:55:00 -0000 Received: from [10.50.40.202] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j2GKsTJR001482; Wed, 16 Mar 2005 15:54:46 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: obrien@FreeBSD.org Date: Wed, 16 Mar 2005 15:34:41 -0500 User-Agent: KMail/1.6.2 References: <200503120029.j2C0TUGn056138@repoman.freebsd.org> <200503160903.45392.jhb@FreeBSD.org> <20050316202056.GB2072@dragon.NUXI.org> In-Reply-To: <20050316202056.GB2072@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200503161534.41120.jhb@FreeBSD.org> X-Spam-Status: No, score=-102.8 required=4.2 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Adam Gregoire cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/conf GENERIC src/sys/conf files.amd64 files.i386 src/sys/dev/nve if_nve.c if_nvereg.h src/sys/i386/conf GENERIC src/sys/modules Makefile src/sys/modules/nve Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2005 20:55:02 -0000 On Wednesday 16 March 2005 03:20 pm, David O'Brien wrote: > On Wed, Mar 16, 2005 at 09:03:45AM -0500, John Baldwin wrote: > > On Sunday 13 March 2005 05:22 pm, David O'Brien wrote: > > > On Sat, Mar 12, 2005 at 12:02:25AM -0500, Adam Gregoire wrote: > > > > On Sat, 2005-03-12 at 00:29 +0000, David E. O'Brien wrote: > > > > This needs to be moved to where the rest of miibus interfaces are in > > > > amd64 and i386 GENERIC kernel config files. > > > > > > ..snip.. > > > > > > > /usr/src/sys/dev/nve/if_nve.c:111:23: miibus_if.h: No such file or > > > > directory > > > > > > Simply moving where they are in GENERIC won't fix this build problem. > > > Is this during the kernel build, or the modules build? > > > > Moving it reduces PEBKAC errors from people not having miibus in their > > custom kernel configs. If it needs miibus, you need to move it to the > > miibus section. > > John, > > I am not auging with moving it. I was saying that moving it w/in GENERIC > wouldn't fix build errors. I guess you might have hit on the issue not > stated in the bug report -- the build probably isn't with GENERIC as > implied, but a majorly cut down minimal kernel config file. Right, it's probably a custom kernel and they diked out miibus since the driver isn't in the miibus "section". Moving the device line would help users from doing this accidentally. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org