From owner-svn-src-head@FreeBSD.ORG Sat Feb 14 20:09:15 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D8A32E2D; Sat, 14 Feb 2015 20:09:15 +0000 (UTC) Received: from pmta1.delivery8.ore.mailhop.org (pmta1.delivery8.ore.mailhop.org [54.191.158.99]) by mx1.freebsd.org (Postfix) with ESMTP id B170BF57; Sat, 14 Feb 2015 20:09:15 +0000 (UTC) Received: from smtp3.ore.mailhop.org (172.31.36.112) by pmta1.delivery1.ore.mailhop.org id hrulm220r840; Sat, 14 Feb 2015 20:08:57 +0000 (envelope-from ) Received: from [73.34.117.227] (helo=ilsoft.org) by smtp3.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YMj1X-0002pl-Jr; Sat, 14 Feb 2015 20:09:07 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t1EK9639015469; Sat, 14 Feb 2015 13:09:06 -0700 (MST) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX18qxpACM1e16AyJMbHyVzhm Message-ID: <1423944546.80968.151.camel@freebsd.org> Subject: Re: Phabricator + 'Reviewed by' [was Re: svn commit: r278472 - in head/sys: netinet netinet6] From: Ian Lepore To: Bryan Drewery Date: Sat, 14 Feb 2015 13:09:06 -0700 In-Reply-To: <54DFA938.6020207@FreeBSD.org> References: <201502091928.t19JSC5P066293@svn.freebsd.org> <38B8D2D0-862A-4DF5-9479-8EC234CF830B@FreeBSD.org> <54DE8F32.2090500@FreeBSD.org> <54DF6709.6030204@freebsd.org> <54DFA938.6020207@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.8 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, Steven Hartland , svn-src-all@freebsd.org, phabric-admin@FreeBSD.org, Randall Stewart , "Bjoern A. Zeeb" , svn-src-head@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2015 20:09:16 -0000 On Sat, 2015-02-14 at 13:59 -0600, Bryan Drewery wrote: > On 2/14/2015 9:17 AM, Steven Hartland wrote: > > > > On 13/02/2015 23:56, Bryan Drewery wrote: > >> On 2/9/2015 3:45 PM, Bjoern A. Zeeb wrote: > >>>> Commented upon by hiren and sbruno > >>>> See Phabricator D1777 for more details. > >>>> > >>>> Commented upon by hiren and sbruno > >>>> Reviewed by: adrian, jhb and bz > >>> I have not reviewed this; as a matter of fact you are aware that I > >>> still wanted to do that. > >>> > >> Something about Phabricator is not jiving with our commit terminology. > >> This has happened before as well with other commits. I'm sure everyone > >> is good-intentioned as well. > >> > >> There's not 1 person on D1777 who has 'accepted' it. That is what > >> warrants a 'Reviewed by' to me. > >> > >> It's clear to me, but seems unclear to others. I really think the > >> reviewer list needs to be split up. Rather than using icons, use > >> separate lists. Reviewers requested: accepted: commented: changes > >> requested:. > > I don't think it needs to be split up, that feels unnecessary, if > > someone hasn't accepted it then they haven't review it period IMO. > > Yes I too think it's obvious, yet I've seen at least 2 commits where the > reviewed by line was essentially a lie. It's in SVN forever now with > those names stamped as reviewers. > You make that sound like some sort of huge crisis, but we have glitches in commit messages (occasionally even a missing/empty message) from time to time, and life goes on. Phabricator is supposed to be a tool to make our lives better and easier, but it could all too easily turn into a stick to hit people with, and the first step on that path is making a bunch of rigid formal rules and procedures. -- Ian