Date: Sun, 13 Nov 2005 16:31:19 +0100 From: Stijn Hoop <stijn@win.tue.nl> To: Andrey Chernov <ache@freebsd.org>, Michael Nottebrock <lofi@FreeBSD.ORG>, freebsd-ports@FreeBSD.ORG, Norikatsu Shigemura <nork@FreeBSD.ORG>, ports@FreeBSD.ORG Subject: Re: Integrated DEBUG related macros to WITH_DEBUG/WITHOUT_DEBUG Message-ID: <20051113153119.GH69544@pcwin002.win.tue.nl> In-Reply-To: <20051113151131.GG69544@pcwin002.win.tue.nl> References: <200511130038.jAD0cgLb043746@sakura.ninth-nine.com> <20051113212402.bf0fe702.nork@FreeBSD.org> <20051113125046.GA44237@nagual.pp.ru> <200511131526.05488.lofi@freebsd.org> <20051113145814.GA74866@nagual.pp.ru> <20051113151131.GG69544@pcwin002.win.tue.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--cfJ13FhsvNR/yOpm
Content-Type: multipart/mixed; boundary="6BvahUXLYAruDZOj"
Content-Disposition: inline
--6BvahUXLYAruDZOj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Nov 13, 2005 at 04:11:31PM +0100, Stijn Hoop wrote:
> On Sun, Nov 13, 2005 at 05:58:14PM +0300, Andrey Chernov wrote:
> > On Sun, Nov 13, 2005 at 03:25:59PM +0100, Michael Nottebrock wrote:
> > > Yes, that's my main gripe with it as well. It's at least imaginable t=
hat=20
> > > people would want to set the same dependency trigger for every port t=
hey=20
> > > install, like WITH_ARTS (although it's just as well imaginable that t=
hey only=20
> > > want it for one or two ports in particular, which we traditionally on=
ly=20
> > > support very badly and ought to fix), but it's hardly imaginable that=
anybody=20
> > > would want every port they install to be built with debug symbols.
> >=20
> > I must note that f.e. global WITH_X11 at least makes some sense, if you=
=20
> > have X11 (with exception that you still need to run some console varian=
ts=20
> > say, remotely, so some way to turn it off per port must exists), but I=
=20
> > can't say even that about global WITH_DEBUG, it is totally useless.
>=20
> I totally agree with that; it's just that having 127 _unobviously_
> named DEBUG knobs is also totally useless.
>=20
> E.g., for audio/arts, do I need to set 'WITH_KDE_DEBUG=3Dyes' to get
> debugging symbols? I don't know and I can't quickly look it up.
>=20
> Michael's proposal for 'WITH_<portname>_DEBUG' is ultimately the way
> to go.
How about this patch to bsd.port.mk? It sets WITH_DEBUG if
WITH_<portname>_DEBUG is defined. Ports then only need to check for
WITH_DEBUG.
--Stijn
--=20
Beware of he who would deny you access to information. For in his heart
he thinks himself your master.
-- Sid Meier, "Sid Meier's Alpha Centauri"
--6BvahUXLYAruDZOj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="bsd.port.mk.DEBUG.diff"
Content-Transfer-Encoding: quoted-printable
--- /home/stijn/FreeBSD/src/bsd.port.mk.orig Sun Nov 13 16:13:44 2005
+++ bsd.port.mk Sun Nov 13 16:29:34 2005
@@ -1375,6 +1375,14 @@
WWWOWN?=3D www
WWWGRP?=3D www
=20
+# Set WITH_DEBUG if WITH_<portname>_DEBUG is defined
+_TMP_DEBUG=3D WITH_${PORTNAME:U}_DEBUG
+.if defined(${_TMP_DEBUG})
+WITH_DEBUG=3D yes
+.else
+.undef WITH_DEBUG
+.endif
+
.endif
# End of pre-makefile section.
=20
--6BvahUXLYAruDZOj--
--cfJ13FhsvNR/yOpm
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFDd1xHY3r/tLQmfWcRAnW4AJ0Xk+TEdK5FCgmUxVgEThQdVE6qjgCgrTdU
R1plYYxApC71nekKYa90mP8=
=1i5A
-----END PGP SIGNATURE-----
--cfJ13FhsvNR/yOpm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051113153119.GH69544>