From owner-svn-src-all@FreeBSD.ORG Thu Nov 14 21:51:10 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC7F6C9F; Thu, 14 Nov 2013 21:51:10 +0000 (UTC) Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7EC0B211C; Thu, 14 Nov 2013 21:51:10 +0000 (UTC) Received: from [209.249.190.124] (port=52111 helo=dhcp-10-2-210-27.hudson-trading.com) by vps.hungerhost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.80.1) (envelope-from ) id 1Vh4oY-0002ca-E3; Thu, 14 Nov 2013 16:51:02 -0500 Content-Type: multipart/signed; boundary="Apple-Mail=_B87F5B80-1D37-4F24-932A-4D376ACF3646"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: svn commit: r258142 - head/sys/net From: George Neville-Neil In-Reply-To: Date: Thu, 14 Nov 2013 16:51:01 -0500 Message-Id: References: <201311142007.rAEK7InH068095@svn.freebsd.org> To: Sergey Kandaurov X-Mailer: Apple Mail (2.1822) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - freebsd.org X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 21:51:10 -0000 --Apple-Mail=_B87F5B80-1D37-4F24-932A-4D376ACF3646 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 14, 2013, at 16:03 , Sergey Kandaurov = wrote: > On 15 November 2013 00:07, George V. Neville-Neil = wrote: >> Author: gnn >> Date: Thu Nov 14 20:07:17 2013 >> New Revision: 258142 >> URL: http://svnweb.freebsd.org/changeset/base/258142 >>=20 >> Log: >> Shift our OUI correctly. >>=20 >> Pointed out by: emaste >>=20 >> Modified: >> head/sys/net/ieee_oui.h >>=20 >> Modified: head/sys/net/ieee_oui.h >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/net/ieee_oui.h Thu Nov 14 19:53:35 2013 = (r258141) >> +++ head/sys/net/ieee_oui.h Thu Nov 14 20:07:17 2013 = (r258142) >> @@ -62,5 +62,5 @@ >> */ >>=20 >> /* Allocate 64K to bhyve */ >> -#define OUI_FREEBSD_BHYVE_LOW OUI_FREEBSD + 0x000001 >> -#define OUI_FREEBSD_BHYVE_HIGH OUI_FREEBSD + 0x00ffff >> +#define OUI_FREEBSD_BHYVE_LOW ((OUI_FREEBSD << 3) + 0x000001) >> +#define OUI_FREEBSD_BHYVE_HIGH ((OUI_FREEBSD << 3) + 0x00ffff) >=20 > Shouldn't it be rather shifted with 24 (3 x 8bits)? Correct, and it should really be an | not a +. I=92ll commit a fix. Best, George --Apple-Mail=_B87F5B80-1D37-4F24-932A-4D376ACF3646 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlKFRcUACgkQYdh2wUQKM9JB9wCeNC9JszmSKr5mlDGYNWOupN3b IycAoLRYRCigL8MPa3YGAZbsKUv2RFih =Vqip -----END PGP SIGNATURE----- --Apple-Mail=_B87F5B80-1D37-4F24-932A-4D376ACF3646--