From owner-freebsd-ports  Thu Jan 29 21:20:04 1998
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id VAA15787
          for freebsd-ports-outgoing; Thu, 29 Jan 1998 21:20:04 -0800 (PST)
          (envelope-from owner-freebsd-ports@FreeBSD.ORG)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id VAA15776;
          Thu, 29 Jan 1998 21:20:02 -0800 (PST)
          (envelope-from gnats)
Received: from aldan.ziplink.net (mi@kot.ne.mediaone.net [24.128.29.55])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA15521
          for <FreeBSD-gnats-submit@freebsd.org>; Thu, 29 Jan 1998 21:18:04 -0800 (PST)
          (envelope-from mi@aldan.ziplink.net)
Received: (from mi@localhost)
	by aldan.ziplink.net (8.8.8/8.8.7) id FAA15016;
	Fri, 30 Jan 1998 05:18:02 GMT
	(envelope-from mi)
Message-Id: <199801300518.FAA15016@aldan.ziplink.net>
Date: Fri, 30 Jan 1998 05:18:02 GMT
From: Mikhail Teterin <mi@aldan.algebra.com>
Reply-To: mi@aldan.algebra.com
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: ports/5602: bsd.port.mk computing checksum ALWAYS even when not needed
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe freebsd-ports"


>Number:         5602
>Category:       ports
>Synopsis:       when files/md5 does not contain a checksum -- do not compute it
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 29 21:20:01 PST 1998
>Last-Modified:
>Originator:     Mikhail Teterin
>Organization:
Virtual Estates, Inc.
>Release:        FreeBSD 3.0-CURRENT
>Environment:

>Description:

	Even when files/md5 says IGNORE, or a checksum is not there,
	bsd.port.mk will still compute the checksum, only to discard it
	later.

>How-To-Repeat:

>Fix:
	
	The following seems to fix the problem. May not be the best solution
	though:

--- /usr/share/mk/bsd.port.mk.orig	Sun Jan 11 14:18:57 1998
+++ /usr/share/mk/bsd.port.mk	Fri Jan 30 00:07:31 1998
@@ -1375,3 +1375,2 @@
 		  for file in ${_CKSUMFILES}; do \
-			CKSUM=`${MD5} < $$file`; \
 			CKSUM2=`${GREP} "^MD5 ($$file)" ${MD5_FILE} | ${AWK} '{print $$4}'`; \
@@ -1384,3 +1383,3 @@
 				OK="false"; \
-			elif [ "$$CKSUM" = "$$CKSUM2" ]; then \
+			elif [ "`${MD5} < $$file`" = "$$CKSUM2" ]; then \
 				${ECHO_MSG} ">> Checksum OK for $$file."; \
>Audit-Trail:
>Unformatted: