From owner-cvs-all@FreeBSD.ORG Fri Apr 4 08:57:42 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 004BE1065677 for ; Fri, 4 Apr 2008 08:57:41 +0000 (UTC) (envelope-from yar.tikhiy@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.186]) by mx1.freebsd.org (Postfix) with ESMTP id 83BB38FC2F for ; Fri, 4 Apr 2008 08:57:41 +0000 (UTC) (envelope-from yar.tikhiy@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1826824nfb.33 for ; Fri, 04 Apr 2008 01:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender; bh=yIhSgvb0oX4c3Wr9B6BolWX3bR5+HKN0sb8qWmyLUg0=; b=Jw/k806wlOwscOlIjlZnwc66dvB3XoxIRxjFbRGAzdX5bs5vxkui32O+WL8rWBeJDD3N2O3hsa1OuDL7WvqcffD8T5QCRQXCWc8fYSyiZFZ1X/Mtmp3zMEZRjYwzMo4cVkabd8cl8k2OB2TrBALay7lymg0HJ7qEgxWPl4PP+VQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender; b=aEqTWF8YNzbAPWhqtEBZ/+mrrwGD1vH7AaWwcJGYhpO9e5gSQyJcKy7X1nVc5cibATqZTpxK70D1IK9pbov1Pfyz7olcQQxXv4opEhQIrNX3ioUoYJtfEryI91c7esb4+Qdv1DM1y/MV4LjBuWbrWl0+A5LwhcoK9zIyEQWHlUs= Received: by 10.78.179.12 with SMTP id b12mr2576365huf.61.1207299459993; Fri, 04 Apr 2008 01:57:39 -0700 (PDT) Received: from dg.local ( [83.237.58.223]) by mx.google.com with ESMTPS id e9sm16392225muf.0.2008.04.04.01.57.38 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Apr 2008 01:57:39 -0700 (PDT) Date: Fri, 4 Apr 2008 12:57:46 +0400 From: Yar Tikhiy To: Craig Rodrigues Message-ID: <20080404085746.GB19086@dg.local> References: <200804040150.m341owGT075760@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200804040150.m341owGT075760@repoman.freebsd.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Yar Tikhiy Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/fsck_ffs main.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2008 08:57:42 -0000 On Fri, Apr 04, 2008 at 01:50:58AM +0000, Craig Rodrigues wrote: > rodrigc 2008-04-04 01:50:58 UTC > > FreeBSD src repository > > Modified files: > sbin/fsck_ffs main.c > Log: > Add comment about specifying "ro" mount option when > doing an update mount on a read-only file system. > > Requested by: yar > > Revision Changes Path > 1.50 +4 -0 src/sbin/fsck_ffs/main.c Thanks! (But see below.) > Index: src/sbin/fsck_ffs/main.c > diff -u src/sbin/fsck_ffs/main.c:1.49 src/sbin/fsck_ffs/main.c:1.50 > --- src/sbin/fsck_ffs/main.c:1.49 Wed Mar 5 08:25:49 2008 > +++ src/sbin/fsck_ffs/main.c Fri Apr 4 01:50:58 2008 > @@ -541,6 +541,10 @@ > build_iovec(&iov, &iovlen, "errmsg", errmsg, > sizeof(errmsg)); > build_iovec(&iov, &iovlen, "update", NULL, 0); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ As I've already pointed out, this line you also added is dangerous because it installs the string "update" to among the root mount point options, which may blow up later with more changes to the mount framework. The option still needs to be spelled MNT_UPDATE and passed as a flag for now. > + /* > + * XX: We need the following line until we clean up > + * nmount parsing of root mounts and NFS root mounts. > + */ > build_iovec(&iov, &iovlen, "ro", NULL, 0); > if (nmount(iov, iovlen, fflags) == 0) { > return (0); -- Yar