From owner-svn-src-head@freebsd.org Sat Nov 11 06:15:01 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13532E61BA8; Sat, 11 Nov 2017 06:15:01 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from c.mail.sonic.net (c.mail.sonic.net [64.142.111.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CDAEC7501D; Sat, 11 Nov 2017 06:15:00 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from zeppelin.tachypleus.net (cpe-23-243-163-238.socal.res.rr.com [23.243.163.238]) (authenticated bits=0) by c.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id vAB6EvpP003204 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 10 Nov 2017 22:14:58 -0800 Subject: Re: svn commit: r325688 - head/sys/boot/powerpc/ps3 To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201711102354.vAANsJDk074902@repo.freebsd.org> From: Nathan Whitehorn Message-ID: <35853e0e-a315-6f76-5431-b922e0f5700d@freebsd.org> Date: Fri, 10 Nov 2017 22:14:57 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <201711102354.vAANsJDk074902@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVZUmBf9UDNw5r9nojzKA4rxKCJwVc4tAA7gkOgBxz5NSC1cDPV5kt3VWRBwW3+LQlMlmTKSC/yX4lQyQCDmeaFIk0x/g3Nv62U= X-Sonic-ID: C;VFNDpKfG5xGYIIKfRUfeDw== M;xHSYpKfG5xGYIIKfRUfeDw== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Nov 2017 06:15:01 -0000 The PS3 port *does* support FDT, though not through this loader. On a related note, I'm planning to just svn rm loader.ps3 in the next few weeks. -Nathan On 11/10/17 15:54, Warner Losh wrote: > Author: imp > Date: Fri Nov 10 23:54:18 2017 > New Revision: 325688 > URL: https://svnweb.freebsd.org/changeset/base/325688 > > Log: > FDT support doesn't make sense for ps3. There's no support in the ps3 > port for FDT, and it's unlikely to grow support for that anytime soon. > When it does, support can be added back easily enough. > > Supported by: Netflix > > Modified: > head/sys/boot/powerpc/ps3/Makefile > > Modified: head/sys/boot/powerpc/ps3/Makefile > ============================================================================== > --- head/sys/boot/powerpc/ps3/Makefile Fri Nov 10 23:54:13 2017 (r325687) > +++ head/sys/boot/powerpc/ps3/Makefile Fri Nov 10 23:54:18 2017 (r325688) > @@ -7,7 +7,6 @@ LOADER_NET_SUPPORT?= yes > LOADER_NFS_SUPPORT?= yes > LOADER_TFTP_SUPPORT?= no > LOADER_GZIP_SUPPORT?= yes > -LOADER_FDT_SUPPORT?= no > LOADER_BZIP2_SUPPORT?= no > > .include > @@ -24,12 +23,6 @@ SRCS+= lv1call.S ps3cons.c font.h ps3mmu.c ps3net.c p > ps3stor.c ps3disk.c ps3cdrom.c > SRCS+= ucmpdi2.c > > -.if ${LOADER_FDT_SUPPORT} == "yes" > -CFLAGS+= -I${FDTSRC} > -CFLAGS+= -DLOADER_FDT_SUPPORT > -LIBFDT= ${BOOTOBJ}/fdt/libfdt.a > -.endif > - > CFLAGS+= -mcpu=powerpc64 > > # Always add MI sources > @@ -55,7 +48,7 @@ SC_DFLT_FONT=cp437 > font.h: > uudecode < /usr/share/syscons/fonts/${SC_DFLT_FONT}-8x16.fnt && file2c 'u_char dflt_font_16[16*256] = {' '};' < ${SC_DFLT_FONT}-8x16 > font.h && uudecode < /usr/share/syscons/fonts/${SC_DFLT_FONT}-8x14.fnt && file2c 'u_char dflt_font_14[14*256] = {' '};' < ${SC_DFLT_FONT}-8x14 >> font.h && uudecode < /usr/share/syscons/fonts/${SC_DFLT_FONT}-8x8.fnt && file2c 'u_char dflt_font_8[8*256] = {' '};' < ${SC_DFLT_FONT}-8x8 >> font.h > > -loader.help: help.common ${FDTSRC}/help.fdt > +loader.help: help.common > cat ${.ALLSRC} | \ > awk -f ${LDRSRC}/merge_help.awk > ${.TARGET} > >