From owner-freebsd-x11@freebsd.org Wed Aug 14 18:03:35 2019 Return-Path: Delivered-To: freebsd-x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ADC23B4B9D for ; Wed, 14 Aug 2019 18:03:35 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467yBH2NHGz3CnD for ; Wed, 14 Aug 2019 18:03:35 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: by mailman.nyi.freebsd.org (Postfix) id 4FC42B4B9C; Wed, 14 Aug 2019 18:03:35 +0000 (UTC) Delivered-To: x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4F716B4B98; Wed, 14 Aug 2019 18:03:35 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 467yBF65wYz3CnB; Wed, 14 Aug 2019 18:03:33 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 72b43d3d; Wed, 14 Aug 2019 20:03:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=0g5Z0PLZxChjRXgEaTHsr7wcBMo=; b=SUO8cdD6YGnXg/df9iELsEHZlsKc azAMx34hZQi3PrM+txxfp8MYKyC16HZIHJd/BC1QHGHfWkoQsdAvPCrMPIIJhhOp Bqmy16qRtLJ2/rUuB43zxWgkKqOpkC/Hm7Hl/maQfzfYwwD73u7EEQEWYxLjbvaa 53XTwWN+8zH3G1I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=jx7OXOYuKq+986sCY6UVLWeakuKFapWTxCRxTiRGTx6VjToM8RFqm28t nBx+IgSdY85fkt+DUuvhMrlBz2PUqlzU0cNMF/WMrEiI465lB3DSWG0O7rfI14c9 qRUXfdNDEBjJ6rj3Zn4HSl4PGLUoBdIotgRLR+y861PFGyccdE4= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 5461d3f5 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 14 Aug 2019 20:03:32 +0200 (CEST) Date: Wed, 14 Aug 2019 20:03:31 +0200 From: Emmanuel Vadot To: Niclas Zeising Cc: John Baldwin , x11@FreeBSD.org, current@FreeBSD.org, Ian Lepore Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-Id: <20190814200331.6a26325941779d1eab55a580@bidouilliste.com> In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467yBF65wYz3CnB X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mail header.b=SUO8cdD6; dmarc=none; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.177.182 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-0.64 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mail]; NEURAL_HAM_MEDIUM(-0.80)[-0.799,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:212.83.177.182/32]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; DMARC_NA(0.00)[bidouilliste.com]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-0.85)[-0.848,0]; NEURAL_SPAM_SHORT(0.56)[0.562,0]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.35)[ip: (-0.93), ipnet: 212.83.160.0/19(2.57), asn: 12876(0.09), country: FR(-0.01)]; ASN(0.00)[asn:12876, ipnet:212.83.160.0/19, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:03:35 -0000 On Wed, 14 Aug 2019 19:55:02 +0200 Niclas Zeising wrote: > On 2019-08-14 19:23, Emmanuel Vadot wrote: > > On Wed, 14 Aug 2019 10:13:48 -0700 > > John Baldwin wrote: > > > >> On 8/14/19 9:22 AM, Ian Lepore wrote: > >>> This all sounds vaguely wrong, backwards, to me. A developer who is > >>> using a given module on their build system might want that module to be > >>> rebuilt automatically, but only if the build parameters match those of > >>> the running build host system. > >>> > >>> If my build host is running freebsd 12 amd64 and I'm doing a build for > >>> freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 > >>> driver module for a different OS arch and version just because that > >>> module happens to be installed on the system I use to do crossbuilds. > >>> > >>> My objections are theoretical... this automation just seems improperly > >>> designed to me. But it won't actually affect me in any way, because I > >>> don't build video driver modules from ports, and I don't run freebsd > >>> current on my build host machine. Probably the number of people doing > >>> crossbuilding is small enough that nobody else is going to object to > >>> this "the whole world is amd64" automation. > >> > >> You assume DRM is amd64-only when it is definitely not. It also has > >> suitable guards in its Makefile to only build the relevant kernel > >> modules on supported architectures. > > > > I clearly don't want to spend time to build the drm and radeon modules > > when I'm hacking on arm64. > > Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a > > subdirectory ? So when you install drm-kmod-* it will only install the > > source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or whatever > > the correct dir is). > > > > I'm not sure what you're trying to accomplish. I might be > misunderstanding completely, but, at least the drm ports have safeguards > in their makefiles so they'll only be built for those arches where there > is support, and only the modules needed, as an example, i915kms.ko will > only be built on amd64 and i386, if that's what you're worried about. > Regards > -- > Niclas Zeising Greg.V is making radeon/amdgpu building on aarch64. So when the ports will have support for it if I don't set some env variable I will spend some time building drm + amdgpu when I buildkernel on my amd64 13-CURRENT machine for aarch64. This is not something that I want to do. So what I said was that if I install drm-kmod-* on an amd64 machine this should only trigger a build of the module when I'm building an amd64 kernel, hence my proposal to only install sources in a ${TARGET}.$ {TARGET_ARCH} subdir. -- Emmanuel Vadot