From owner-svn-src-all@FreeBSD.ORG Wed Oct 22 15:37:33 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7B5466C3; Wed, 22 Oct 2014 15:37:33 +0000 (UTC) Received: from mail-pd0-x22a.google.com (mail-pd0-x22a.google.com [IPv6:2607:f8b0:400e:c02::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3DF17A35; Wed, 22 Oct 2014 15:37:33 +0000 (UTC) Received: by mail-pd0-f170.google.com with SMTP id z10so3762573pdj.1 for ; Wed, 22 Oct 2014 08:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WnTsoWhQEyHnDEzuddaW1UO5JBSTDlaBcJM5o4zuPiU=; b=GyY2+Y91Y+zO1YMULBK5Th7xiprMQxvoOlvbawH8tKizg6yWkayQa/xwGXQJJHkqem eOWv0+nhEX52wNOZJPhDsF99cFDHCHoY6VXnzZGL0YWL0Lm0zrcQbKdmArRnxNerlLyX NAnVssQ2ZA2LGae07QUnJlBvoZHwxOcPTI6MhYupicGYA8+SoJaUXkoqGXOC6IOyqW48 pYVKeLFICtv5xVUNmtnLvkTevHnk4yFc7P/2Pq4tVSLIkj/tF6DIev0UUFtgOGZX6swi 6CKk2ifZnVBfRwLZ/dtdwEuFg6bbQC1S53za1W9ZypKQi2ZWls0LZK4030CyEqDkXMHF yVcw== MIME-Version: 1.0 X-Received: by 10.66.66.167 with SMTP id g7mr43773201pat.66.1413992252915; Wed, 22 Oct 2014 08:37:32 -0700 (PDT) Received: by 10.70.9.132 with HTTP; Wed, 22 Oct 2014 08:37:32 -0700 (PDT) In-Reply-To: <1413992086.12052.548.camel@revolution.hippie.lan> References: <201410212029.s9LKThT2074337@svn.freebsd.org> <86d29k28wh.fsf@nine.des.no> <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> <86iojco2oh.fsf@nine.des.no> <6287010D-9C54-4167-9784-84134080A419@bsdimp.com> <86mw8ocftw.fsf@nine.des.no> <1413992086.12052.548.camel@revolution.hippie.lan> Date: Wed, 22 Oct 2014 11:37:32 -0400 Message-ID: Subject: Re: svn commit: r273417 - head From: Benjamin Kaduk To: Ian Lepore Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers , Warner Losh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 15:37:33 -0000 On Wed, Oct 22, 2014 at 11:34 AM, Ian Lepore wrote: > On Wed, 2014-10-22 at 11:00 -0400, Benjamin Kaduk wrote: > > On Wed, Oct 22, 2014 at 10:57 AM, Dag-Erling Sm=C3=B8rgrav > wrote: > > > > > Is _SUPPORT magic? I didn't know. I guess MK_TESTS_SUPPORT is good > > > enough, especially if it's on by default. > > > > > > Even if it is magic, is that really the kind of magic we want to be > keeping > > around? > > > > -Ben > > I didn't really think of it as magic so much as analogous to INVARIANTS > vs INVARIANTS_SUPPORT in kernel config. > I can put INVARIANTS but not INVARIANTS_SUPPORT in my kernel config ... and it gives me a somewhat inscrutable build error. I didn't get the impression that's what's going on with MK_TESTS... -Ben