Date: Fri, 25 Apr 2008 15:04:59 +0200 From: Roman Divacky <rdivacky@FreeBSD.org> To: Kris Kennaway <kris@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c Message-ID: <20080425130459.GA70110@freebsd.org> In-Reply-To: <200804242208.m3OM8a12040177@repoman.freebsd.org> References: <200804242208.m3OM8a12040177@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 24, 2008 at 10:08:36PM +0000, Kris Kennaway wrote: > kris 2008-04-24 22:08:36 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_descrip.c > Log: > fdhold can return NULL, so add the one remaining missing check for this > condition. fdp = fdhold(p); + if (fdp == NULL) + return (0); PROC_UNLOCK(p); I think you leak the PROC lock here...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080425130459.GA70110>