From owner-freebsd-current@FreeBSD.ORG Mon Jan 17 05:36:57 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C5DE16A4CE; Mon, 17 Jan 2005 05:36:57 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB55B43D3F; Mon, 17 Jan 2005 05:36:56 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id j0H5atl9096410; Sun, 16 Jan 2005 21:36:55 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id j0H5atPh096409; Sun, 16 Jan 2005 21:36:55 -0800 (PST) (envelope-from obrien) Date: Sun, 16 Jan 2005 21:36:55 -0800 From: "David O'Brien" To: Garance A Drosihn Message-ID: <20050117053655.GA96378@dragon.nuxi.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: freebsd-current@freebsd.org cc: Robert Watson Subject: Re: gratuitous gcc warnings: unused function arguments? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2005 05:36:57 -0000 On Sun, Jan 16, 2005 at 07:51:35PM -0500, Garance A Drosihn wrote: > At 9:05 PM +0000 1/16/05, Robert Watson wrote: > >On Sun, 16 Jan 2005, David O'Brien wrote: > > > We're not going to hack GCC to deal with this. That is going way > > > too far. This is coming up because people are using high WARNS > > > values in Makefiles. Either back them down to a lower WARNS value; > > > or we should add -Wno-unused-parameter to WARNS level 3. > > > >I'd be fine with simply pushing threshold for unused parameters up > >a few notches on the warning scale. I'd like to have access to the > >other interesting warnings are WARNS=3 and WARNS=4 relating to > >qualifiers, strings, etc. > > I think it would be useful to keep that warning "in general", but > have an option to turn it off. The following seems to work for me, > assuming we can decide on the best name for a new NO_WUNUSED_ARGS > option: Do you have a piece of code that exhibits this warning but otherwise could pass at higher warning level? I'm reisitance to adding a lot of NO_FOO_WARNING knobs. Otherwise we might as well as remove the whole WARNS thing and set each warning a Makefile wants. -- -- David (obrien@FreeBSD.org)