From owner-cvs-all  Sat Dec  1 11:15:10 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id F1FD437B417; Sat,  1 Dec 2001 11:15:04 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id GAA03407;
	Sun, 2 Dec 2001 06:15:02 +1100
Date: Sun, 2 Dec 2001 06:15:14 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Mark Murray <markm@FreeBSD.org>
Cc: <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/usr.bin/login Makefile login.c login.h        
 login_access.c login_fbtab.c
In-Reply-To: <200112011746.fB1HkkF66547@freefall.freebsd.org>
Message-ID: <20011202060856.F5933-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sat, 1 Dec 2001, Mark Murray wrote:

> markm       2001/12/01 09:46:46 PST
>
>   Modified files:
>     usr.bin/login        Makefile login.c login_access.c
>                          login_fbtab.c
>   Added files:
>     usr.bin/login        login.h
>   Log:
>   WARNS=2 fixes.

This breaks the world due to namespace pollution in <security/pam_misc.h>:

! cc1: warnings being treated as errors
! In file included from /tmp/login/login.c:82:
! /usr/include/security/pam_misc.h:38: warning: declaration of `send' shadows global declaration

>   Reviewed by:    bde (a while back)

I actually reviewed a different version.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message