From owner-freebsd-current@FreeBSD.ORG  Thu Jan 15 09:33:04 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 844B416A4CE; Thu, 15 Jan 2004 09:33:04 -0800 (PST)
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by mx1.FreeBSD.org (Postfix) with SMTP
	id A0EB643D6B; Thu, 15 Jan 2004 09:32:57 -0800 (PST)
	(envelope-from dwmalone@maths.tcd.ie)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa71029@salmon>; 15 Jan 2004 17:32:56 +0000 (GMT)
Date: Thu, 15 Jan 2004 17:32:56 +0000
From: David Malone <dwmalone@maths.tcd.ie>
To: Andre Oppermann <andre@freebsd.org>
Message-ID: <20040115173256.GA31297@walton.maths.tcd.ie>
References: <4006BC29.7CAE053B@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4006BC29.7CAE053B@freebsd.org>
User-Agent: Mutt/1.5.3i
Sender: dwmalone@maths.tcd.ie
cc: freebsd-current@freebsd.org
Subject: Re: uipc_socket2.c sbflush question
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2004 17:33:04 -0000

On Thu, Jan 15, 2004 at 05:13:29PM +0100, Andre Oppermann wrote:
> Why is sbdrop() called directly instead of sbflush()?  I think it makes
> more sense to change that to a call to sbflush() which then DTRT?

If I remember correctly, it was to deal with the fact that
soisdisconnected is sometimes called without the socket being locked,
but sbflush required the socket to have SB_LOCK set.

(You used to get a panic fairly quickly if you did s/sbdrop/sbflush/)

	David.