From owner-cvs-all Fri Jun 1 22:36:31 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id E442F37B43C; Fri, 1 Jun 2001 22:36:25 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f525aPW52146; Sat, 2 Jun 2001 01:36:25 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20010601123333.A4533@dragon.nuxi.com> References: <200106010007.f5107AY14009@freefall.freebsd.org> <20010531231614.A64344@dragon.nuxi.com> <20010601123333.A4533@dragon.nuxi.com> Date: Sat, 2 Jun 2001 01:36:22 -0400 To: obrien@FreeBSD.org From: Garance A Drosihn Subject: Re: cvs commit: src/bin/sh eval.c Cc: Garance A Drosehn , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 12:33 PM -0700 6/1/01, David O'Brien wrote: >On Fri, Jun 01, 2001 at 12:14:48PM -0400, Garance A Drosihn wrote: >> At 11:16 PM -0700 5/31/01, David O'Brien wrote: >> >On Thu, May 31, 2001, Garance A Drosehn wrote: >> > > Modified files: >> >> bin/sh eval.c >> >> Log: >> > > Fix how /bin/sh handles 'for' and 'case' statements when it is >> > > called to do errexit (-e) processing. >> > >> >Was this reviewed by cracauer? He has been doing the care and >> >feeding of ash for along time and he really up on the subtleties >> >of the various standards that address `sh'. >> >> I sent a message on Monday, but haven't received a reply. > >A 3 day timeout is not reasonable in our environment. The change adds two lines, which in the context of the routine are pretty safe lines to add. There is even a comment later in the routine which says * XXX - Like "!(n->type == NSEMI)", more types will * probably need to be excluded from this test. It's * probably better to set or unset EV_TESTED in the * loop above than to bloat the conditional here. I'll back it out if people are really bothered by it, but I am confident that it's a safe change to make, and I know it fixes '-e' processing in some situations where I am certain that ash was not doing the correct thing. I do not intend to MFC this for at least two weeks, and given the way my schedule goes that is more likely to end up being three or four weeks. Would it make people feel comfortable enough if I expand that to say that I won't MFC it until cracauer has ok'ed it? -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message